Skip to content

Commit 14051f8

Browse files
authored
Merge pull request #157 from terminusdb/review_table
Review table
2 parents acc700b + 8e5cb53 commit 14051f8

File tree

12 files changed

+68
-25
lines changed

12 files changed

+68
-25
lines changed

package-lock.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/tdb-access-control-component/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@terminusdb/terminusdb-access-control-component",
3-
"version": "6.1.3",
3+
"version": "6.1.4",
44
"description": "Table for terminusdb",
55
"main": "src/index",
66
"module": "es6/index",

packages/tdb-dashboard/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@terminusdb-live/tdb-dashboard",
3-
"version": "6.1.3",
3+
"version": "6.1.4",
44
"description": "react",
55
"homepage": "./",
66
"main": "src/index",

packages/tdb-dashboard/src/index.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,16 @@ function NavigationComponent(){
1818
let navigate = useNavigate();
1919
const redirect_uri = window.location.origin
2020

21+
22+
// this happen after confirm you password linking in the email url
23+
/* if (window.location.search.includes("supportSignUp=true")) {
24+
// window.location.replace('/')
25+
}*/
26+
// you enter here only if you are log - in
2127
const onRedirectCallback = (appState) => {
28+
2229
navigate(appState && appState.targetUrl ? appState.targetUrl : window.location.pathname);
30+
2331
};
2432

2533
if(localSettings && localSettings.connection_type!== "LOCAL"){

packages/tdb-documents-ui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@terminusdb/terminusdb-documents-ui",
3-
"version": "6.1.3",
3+
"version": "6.1.4",
44
"description": "SDK to build UI from terminusdb documents",
55
"main": "src/index.js",
66
"module": "es6/index",

packages/tdb-react-components/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@terminusdb-live/tdb-react-components",
3-
"version": "6.1.3",
3+
"version": "6.1.4",
44
"description": "components tools for terminusdb",
55
"main": "src/index",
66
"module": "es6/index",

packages/tdb-react-table/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@terminusdb/terminusdb-react-table",
3-
"version": "6.1.3",
3+
"version": "6.1.4",
44
"description": "Table for terminusdb",
55
"main": "src/index",
66
"module": "es6/index",

packages/tdb-react-table/src/ColumsVisibilityComponent.js

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ const CheckboxMenu = React.forwardRef(
99
children,
1010
style,
1111
className,
12+
setHiddenColumns,
1213
"aria-labelledby": labeledBy,
1314
onChange,
1415
title,
@@ -19,7 +20,8 @@ const CheckboxMenu = React.forwardRef(
1920
const label = checked ? "Hide All" : "Show All"
2021

2122
const setHideShow = (evt)=>{
22-
onChange(!checked)
23+
if(setHiddenColumns)setHiddenColumns("__ALL__",!checked)
24+
onChange(evt)
2325
}
2426

2527
return (<div
@@ -44,7 +46,7 @@ const CheckboxMenu = React.forwardRef(
4446
type="checkbox"
4547
label={"All"}
4648
checked={checked}
47-
onChange={onChange}
49+
onChange={setHideShow}
4850
className= "table__columns__component"
4951
/>
5052
</Form.Group>
@@ -56,14 +58,19 @@ const CheckboxMenu = React.forwardRef(
5658
);
5759

5860
const CheckDropdownItem = React.forwardRef(
59-
({ children, id, checked, onChange }, ref) => {
61+
({ children, id, checked, onChange , setHiddenColumns}, ref) => {
62+
function hideShowColumn(evt){
63+
if(setHiddenColumns)setHiddenColumns(id,evt.target.checked)
64+
onChange(evt)
65+
}
66+
6067
return (
6168
<Form.Group ref={ref} className="dropdown-item mb-0" controlId={id}>
6269
<Form.Check
6370
type="checkbox"
6471
label={children}
6572
checked={checked}
66-
onChange={onChange}
73+
onChange={hideShowColumn}
6774
className= "table__columns__component"
6875
/>
6976
</Form.Group>
@@ -72,7 +79,7 @@ const CheckDropdownItem = React.forwardRef(
7279
);
7380

7481

75-
export const CheckboxDropdown = ({ allColumns,getToggleHideAllColumnsProps }) => {
82+
export const CheckboxDropdown = ({setHiddenColumns, allColumns,getToggleHideAllColumnsProps }) => {
7683
return (
7784
<Dropdown>
7885
<Dropdown.Toggle variant="primary" id="dropdown-basic" className="bg-light text-dark">
@@ -81,13 +88,15 @@ export const CheckboxDropdown = ({ allColumns,getToggleHideAllColumnsProps }) =>
8188

8289
<Dropdown.Menu
8390
as={CheckboxMenu}
91+
setHiddenColumns={setHiddenColumns}
8492
{...getToggleHideAllColumnsProps()}
8593
>
8694
{allColumns.map(column => (
8795

8896
<Dropdown.Item
8997
key={column.id}
9098
as={CheckDropdownItem}
99+
setHiddenColumns={setHiddenColumns}
91100
id={column.id}
92101
{...column.getToggleHiddenProps()}>
93102
{column.Header}

packages/tdb-react-table/src/GraphqlTable.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ minWidth,
2020
maxWidth}]*/
2121

2222
//this only render the logic of do the query is in an external hook
23-
export const GraphqlTable = ({hiddenColumnsArr, result, config, freewidth, start, filtersBy ,limit, orderBy, totalRows, setLimits, setOrder, setFilters,onRefresh,dowloadConfig})=>{
23+
export const GraphqlTable = ({hiddenColumnsArr, setHiddenColumns,result, config, freewidth, start, filtersBy ,limit, orderBy, totalRows, setLimits, setOrder, setFilters,onRefresh,dowloadConfig})=>{
2424
// let wt = TerminusClient.View.table()
2525
// if(view) wt.loadJSON(view.table, view.rules)
2626

@@ -68,17 +68,17 @@ export const GraphqlTable = ({hiddenColumnsArr, result, config, freewidth, start
6868
};
6969

7070
function formatTableColumns(){
71-
const hiddenColumns = [] //hiddenColumnsArr
71+
const hiddenColumns = hiddenColumnsArr || []
7272
// I visualise the id only if it is the only item
7373
const colArr = config.columns
7474
if(!Array.isArray(colArr))return []
7575

76-
if(colArr.length > 1){
76+
if(!hiddenColumnsArr && colArr.length > 1){
7777
hiddenColumns.push("_id")
7878
}
7979

8080
let listOfColumns = colArr.map((item,index) => {
81-
if(index>4){
81+
if(!hiddenColumnsArr && index>4){
8282
hiddenColumns.push(item.id)
8383
}
8484
let col = item
@@ -144,6 +144,7 @@ export const GraphqlTable = ({hiddenColumnsArr, result, config, freewidth, start
144144
</Col>
145145
</Row>}
146146
<ReactTableComponent
147+
setHiddenColumns = {setHiddenColumns}
147148
setFilters={setFilters}
148149
data={data}
149150
columns={[{columns:columns,Header:" "}]}

packages/tdb-react-table/src/ReactTableComponent.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import { DefaultColumnFilter } from './ColumnFilters';
1111
* sort - no, local, remote
1212
*/
1313

14-
export const ReactTableComponent = ({columns, data, limit, config, pages, freewidth, filtersBy, orderBy, rowCount, pageNumber, setLimits, setOrder, setFilters, pagesizes, onRefresh,hiddenColumns})=>{
14+
export const ReactTableComponent = ({setHiddenColumns, columns, data, limit, config, pages, freewidth, filtersBy, orderBy, rowCount, pageNumber, setLimits, setOrder, setFilters, pagesizes, onRefresh,hiddenColumns})=>{
1515

1616
// console.log("COLUMS", JSON.stringify(columns,null,4))
1717

@@ -114,7 +114,7 @@ export const ReactTableComponent = ({columns, data, limit, config, pages, freewi
114114
<span>
115115
<div className='d-flex justify-content-end'>
116116
{setFilters && <Button title="Reset filters" className="bg-light text-dark" onClick={() => setAllFilters([])}><MdOutlineResetTv/></Button>}
117-
<CheckboxDropdown allColumns={allColumns} getToggleHideAllColumnsProps={getToggleHideAllColumnsProps}/>
117+
<CheckboxDropdown setHiddenColumns={setHiddenColumns} allColumns={allColumns} getToggleHideAllColumnsProps={getToggleHideAllColumnsProps}/>
118118
</div>
119119
<div className="h-4" />
120120
<Table {...getTableProps()} hover >

0 commit comments

Comments
 (0)