Skip to content

Commit 1cf75ad

Browse files
authored
Merge pull request #223 from terminusdb/fix_pagination
fix pagination loading
2 parents 96508de + f45a836 commit 1cf75ad

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

packages/tdb-dashboard/src/components/DiffView.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -185,12 +185,12 @@ function DiffViewDocument ({documentID,diffObj, CRObject,propertyModifiedCount,f
185185
export const DiffView = ({diffs, CRObject, changePage, start,frames}) => {
186186
let elements=[], paginationItems=[]
187187

188-
if(!frames) return <Loading message={`Loading Frames ...`}/>
189-
if(!diffs) return <Loading message={`Loading Diffs ...`}/>
188+
// maybe we review this and add extra control
189+
if(!frames) return <Loading message={`Loading Frames ...`}/>
190+
if(!diffs) return <Loading message={`Loading Diffs ...`}/>
190191

191192
for (let start=0; start<5; start++) {
192-
if(start >= diffs.length) continue
193-
193+
if(start >= diffs.length) continue
194194
const propertyModifiedCount = getPropertyModifiedCount(diffs[start])
195195
const diffObj = diffs[start]
196196
const action = diffObj["@op"] || "Change"

packages/tdb-dashboard/src/hooks/useDiff.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ export function useDiff(){
5454

5555
async function getDiffList(changeRequestID, start=0, count=DIFFS_PER_PAGE_LIMIT) {
5656
try{
57+
setLoading(true)
5758
setStart(start)
5859
if(totalResult[`start__${start}`]){
5960
setResult(totalResult[`start__${start}`])

0 commit comments

Comments
 (0)