outputs repaired and tests added to prove counts (#67)

* outputs repaired and tests added to prove counts

Author: brandonjbjelland

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/) and this
 project adheres to [Semantic Versioning](http://semver.org/).
 
+## [[v3.3.1](https://github.com/terraform-aws-modules/terraform-aws-alb/compare/v3.3.0...v3.3.1)] - 2018-05-06]
+
+### Changed
+
+* sliced outputs were appended with a `- 1` in debugging. This introduced a bug which was fixed and verified through test.
+
 ## [[v3.3.0](https://github.com/terraform-aws-modules/terraform-aws-alb/compare/v3.2.0...v3.3.0)] - 2018-05-04]
 
 ### Added

examples/alb_test_fixture/outputs.tf

@@ -29,3 +29,15 @@ output "target_group_arns" {
 output "vpc_id" {
   value = "${module.vpc.vpc_id}"
 }
+
+output "target_groups_count" {
+  value = "${local.target_groups_count}"
+}
+
+output "https_listeners_count" {
+  value = "${local.https_listeners_count}"
+}
+
+output "http_tcp_listeners_count" {
+  value = "${local.http_tcp_listeners_count}"
+}

outputs.tf

@@ -5,22 +5,22 @@ output "dns_name" {
 
 output "http_tcp_listener_arns" {
   description = "The ARN of the TCP and HTTP load balancer listeners created."
-  value       = "${slice(concat(aws_lb_listener.frontend_http_tcp.*.arn, list("")), 0, var.http_tcp_listeners_count - 1)}"
+  value       = "${slice(concat(aws_lb_listener.frontend_http_tcp.*.arn, list("")), 0, var.http_tcp_listeners_count)}"
 }
 
 output "http_tcp_listener_ids" {
   description = "The IDs of the TCP and HTTP load balancer listeners created."
-  value       = "${slice(concat(aws_lb_listener.frontend_http_tcp.*.id, list("")), 0, var.http_tcp_listeners_count - 1)}"
+  value       = "${slice(concat(aws_lb_listener.frontend_http_tcp.*.id, list("")), 0, var.http_tcp_listeners_count)}"
 }
 
 output "https_listener_arns" {
   description = "The ARNs of the HTTPS load balancer listeners created."
-  value       = "${slice(concat(aws_lb_listener.frontend_https.*.arn, list("")), 0, var.https_listeners_count - 1)}"
+  value       = "${slice(concat(aws_lb_listener.frontend_https.*.arn, list("")), 0, var.https_listeners_count)}"
 }
 
 output "https_listener_ids" {
   description = "The IDs of the load balancer listeners created."
-  value       = "${slice(concat(aws_lb_listener.frontend_https.*.id, list("")), 0, var.https_listeners_count - 1)}"
+  value       = "${slice(concat(aws_lb_listener.frontend_https.*.id, list("")), 0, var.https_listeners_count)}"
 }
 
 output "load_balancer_arn_suffix" {
@@ -40,7 +40,7 @@ output "load_balancer_zone_id" {
 
 output "target_group_arns" {
   description = "ARNs of the target groups. Useful for passing to your Auto Scaling group."
-  value       = "${slice(concat(aws_lb_target_group.main.*.arn, list("")), 0, var.target_groups_count - 1)}"
+  value       = "${slice(concat(aws_lb_target_group.main.*.arn, list("")), 0, var.target_groups_count)}"
 }
 
 output "target_group_arn_suffixes" {
@@ -50,5 +50,5 @@ output "target_group_arn_suffixes" {
 
 output "target_group_names" {
   description = "Name of the target group. Useful for passing to your CodeDeploy Deployment Group."
-  value       = "${slice(concat(aws_lb_target_group.main.*.name, list("")), 0, var.target_groups_count - 1)}"
+  value       = "${slice(concat(aws_lb_target_group.main.*.name, list("")), 0, var.target_groups_count)}"
 }

test/integration/default/test_alb.rb

@@ -8,13 +8,19 @@
 http_tcp_listener_arns = tf_state['modules'][0]['outputs']['http_tcp_listener_arns']['value']
 https_listener_arns = tf_state['modules'][0]['outputs']['https_listener_arns']['value']
 target_group_arns = tf_state['modules'][0]['outputs']['target_group_arns']['value']
+http_tcp_listeners_count = tf_state['modules'][0]['outputs']['http_tcp_listeners_count']['value']
+https_listeners_count = tf_state['modules'][0]['outputs']['https_listeners_count']['value']
+target_groups_count = tf_state['modules'][0]['outputs']['target_groups_count']['value']
 # rubocop:enable LineLength
 alb_arn = tf_state['modules'][0]['outputs']['alb_id']['value']
 alb_name = alb_arn.split('/')[-2]
 region = tf_state['modules'][0]['outputs']['region']['value']
 ENV['AWS_REGION'] = region
 vpc_id = tf_state['modules'][0]['outputs']['vpc_id']['value']
 security_group_id = tf_state['modules'][0]['outputs']['sg_id']['value']
+count_cases = [[target_group_arns, target_groups_count],
+               [http_tcp_listener_arns, http_tcp_listeners_count],
+               [https_listener_arns, https_listeners_count]]
 
 describe alb(alb_name) do
   it { should exist }
@@ -68,3 +74,11 @@
     its(:port) { should eq(80).or(eq(8080).or(eq(8081))) }
   end
 end
+
+count_cases.each do |test_case|
+  describe test_case[0] do
+    it 'should be predetermined length' do
+      expect(test_case[0].length).to eq(test_case[1].to_i)
+    end
+  end
+end

version

@@ -1 +1 @@
-v3.3.0
+v3.3.1