Skip to content

Commit c74dfb9

Browse files
alexjurkiewiczbrandonjbjelland
authored andcommitted
Remove region (#30)
* Remove explicit aws provider as rovider should be inherited implcitly from the parent, or explicitly overridden by the caller: https://www.terraform.io/docs/modules/usage.html#providers-within-modules
1 parent b94a4b9 commit c74dfb9

File tree

4 files changed

+5
-10
lines changed

4 files changed

+5
-10
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](http://keepachangelog.com/) and this
66
project adheres to [Semantic Versioning](http://semver.org/).
77

8+
## [v2.4.0] - Unreleased
9+
10+
* Remove `region` input. If you'd like to customise the AWS provider configuration, this is supported using the new `providers` input which is a core Terraform feature. [Read more.](https://www.terraform.io/docs/modules/usage.html#providers-within-modules)
11+
812
## [v2.3.2] - 2017-12-18
913

1014
### Added

main.tf

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
11
### ALB resources
22

3-
provider "aws" {
4-
region = "${var.region}"
5-
version = ">= 1.0.0"
6-
}
7-
83
resource "aws_alb" "main" {
94
name = "${var.alb_name}"
105
subnets = ["${var.subnets}"]

variables.tf

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,6 @@ variable "alb_security_groups" {
1818
type = "list"
1919
}
2020

21-
variable "region" {
22-
description = "AWS region to use."
23-
}
24-
2521
variable "backend_port" {
2622
description = "The port the service on the EC2 instances listen on."
2723
default = 80

version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v2.3.2
1+
v2.4.0

0 commit comments

Comments
 (0)