Create bucket before provisioning access logs on the ALB

* Create bucket before provisioning access logs on the ALB
* gemfile fixed to pull from rubygems

Author: zxjinn

Gemfile

@@ -4,10 +4,5 @@ source 'https://rubygems.org/' do
   gem 'kitchen-verifier-awspec'
   gem 'rhcl'
   gem 'awspec'
+  gem 'kitchen-terraform', '>= 3.0.0'
 end
-
-gem(
-  "kitchen-terraform",
-  git: "https://github.com/newcontext-oss/kitchen-terraform",
-  branch: "ncs-alane-3.0.0"
-)

main.tf

@@ -17,6 +17,8 @@ resource "aws_alb" "main" {
     prefix  = "${var.log_location_prefix}"
     enabled = "${var.enable_logging}"
   }
+
+  depends_on = ["aws_s3_bucket.log_bucket"]
 }
 
 data "aws_iam_policy_document" "bucket_policy" {

variables.tf

@@ -96,7 +96,7 @@ variable "enable_logging" {
 }
 
 variable "log_bucket_name" {
-  description = "S3 bucket for storing ALB access logs. Setting this means the module will try to create the bucket."
+  description = "S3 bucket for storing ALB access logs. To create the bucket \"create_log_bucket\" should be set to true."
   default     = ""
 }