File tree Expand file tree Collapse file tree 4 files changed +17
-15
lines changed
Expand file tree Collapse file tree 4 files changed +17
-15
lines changed Original file line number Diff line number Diff line change 11repos :
22 - repo : https://github.com/antonbabenko/pre-commit-terraform
3- rev : v1.74.2
3+ rev : v1.75.0
44 hooks :
55 - id : terraform_fmt
66 - id : terraform_validate
Original file line number Diff line number Diff line change @@ -107,10 +107,11 @@ module "app_runner_image_base" {
107107 }
108108 }
109109
110- create_custom_domain_association = true
111- hosted_zone_id = " Z067530812I2IA0AIKZEV"
112- domain_name = " apprunner.sharedservices.clowd.haus"
113- enable_www_subdomain = true
110+ # # Requires manual intervention to validate records
111+ # create_custom_domain_association = true
112+ # hosted_zone_id = "Z067530812I2IA0AIKZEV"
113+ # domain_name = "apprunner.sharedservices.clowd.haus"
114+ # enable_www_subdomain = true
114115
115116 create_vpc_connector = true
116117 vpc_connector_subnets = module. vpc . private_subnets
Original file line number Diff line number Diff line change @@ -308,6 +308,7 @@ resource "aws_apprunner_custom_domain_association" "this" {
308308 service_arn = aws_apprunner_service. this [0 ]. arn
309309}
310310
311+ # # Requires manual intervention to validate records
311312# resource "aws_route53_record" "validation" {
312313# count = length(aws_apprunner_custom_domain_association.this[0].certificate_validation_records)
313314
@@ -348,15 +349,15 @@ resource "aws_apprunner_custom_domain_association" "this" {
348349# }
349350
350351# resource "aws_route53_record" "alias" {
351- # count = local.create_custom_domain_association && var.domain_name_use_cname ? 1 : 0
352+ # for_each = { for k, v in toset(["A", "AAAA"]) : k => v if local.create_custom_domain_association && var.domain_name_use_cname }
352353
353354# zone_id = var.hosted_zone_id
354- # name = "example.com"
355- # type = "A"
355+ # name = var.domain_name
356+ # type = each.value
356357
357358# alias {
358- # name = aws_elb.main.dns_name
359- # zone_id = aws_elb.main.zone_id
359+ # name = aws_apprunner_service.this[0].service_url
360+ # zone_id = <TODO> ???
360361# evaluate_target_health = true
361362# }
362363# }
Original file line number Diff line number Diff line change @@ -188,11 +188,11 @@ variable "enable_www_subdomain" {
188188 default = null
189189}
190190
191- variable "hosted_zone_id" {
192- description = " The ID of the Route53 hosted zone that contains the domain for the `domain_name`"
193- type = string
194- default = " "
195- }
191+ # variable "hosted_zone_id" {
192+ # description = "The ID of the Route53 hosted zone that contains the domain for the `domain_name`"
193+ # type = string
194+ # default = ""
195+ # }
196196
197197# ###############################################################################
198198# VPC Connector
You can’t perform that action at this time.
0 commit comments