Skip to content

Commit 5a53f39

Browse files
authored
feat: Added a possibility to allow private hosted zone usage (#250)
1 parent ef36521 commit 5a53f39

File tree

6 files changed

+14
-7
lines changed

6 files changed

+14
-7
lines changed

README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,14 +226,14 @@ allow_github_webhooks = true
226226
| Name | Version |
227227
|------|---------|
228228
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 0.13.1 |
229-
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 3.45 |
229+
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | ~> 3.45 |
230230
| <a name="requirement_random"></a> [random](#requirement\_random) | >= 2.0 |
231231

232232
## Providers
233233

234234
| Name | Version |
235235
|------|---------|
236-
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 3.45 |
236+
| <a name="provider_aws"></a> [aws](#provider\_aws) | ~> 3.45 |
237237
| <a name="provider_random"></a> [random](#provider\_random) | >= 2.0 |
238238

239239
## Modules
@@ -372,6 +372,7 @@ allow_github_webhooks = true
372372
| <a name="input_public_subnets"></a> [public\_subnets](#input\_public\_subnets) | A list of public subnets inside the VPC | `list(string)` | `[]` | no |
373373
| <a name="input_readonly_root_filesystem"></a> [readonly\_root\_filesystem](#input\_readonly\_root\_filesystem) | Determines whether a container is given read-only access to its root filesystem. Due to how Terraform type casts booleans in json it is required to double quote this value | `bool` | `false` | no |
374374
| <a name="input_repository_credentials"></a> [repository\_credentials](#input\_repository\_credentials) | Container repository credentials; required when using a private repo. This map currently supports a single key; "credentialsParameter", which should be the ARN of a Secrets Manager's secret holding the credentials | `map(string)` | `null` | no |
375+
| <a name="input_route53_private_zone"></a> [route53\_private\_zone](#input\_route53\_private\_zone) | Enable to use a private Route53 zone | `bool` | `false` | no |
375376
| <a name="input_route53_record_name"></a> [route53\_record\_name](#input\_route53\_record\_name) | Name of Route53 record to create ACM certificate in and main A-record. If null is specified, var.name is used instead. Provide empty string to point root domain name to ALB. | `string` | `null` | no |
376377
| <a name="input_route53_zone_name"></a> [route53\_zone\_name](#input\_route53\_zone\_name) | Route53 zone name to create ACM certificate in and main A-record, without trailing dot | `string` | `""` | no |
377378
| <a name="input_security_group_ids"></a> [security\_group\_ids](#input\_security\_group\_ids) | List of one or more security groups to be added to the load balancer | `list(string)` | `[]` | no |

examples/github-complete/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,14 @@ Go to https://eu-west-1.console.aws.amazon.com/ecs/home?region=eu-west-1#/settin
3030
| Name | Version |
3131
|------|---------|
3232
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 0.13.1 |
33-
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 3.45 |
33+
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | ~> 3.45 |
3434
| <a name="requirement_github"></a> [github](#requirement\_github) | >= 4.8 |
3535

3636
## Providers
3737

3838
| Name | Version |
3939
|------|---------|
40-
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 3.45 |
40+
| <a name="provider_aws"></a> [aws](#provider\_aws) | ~> 3.45 |
4141

4242
## Modules
4343

examples/github-complete/versions.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ terraform {
44
required_providers {
55
aws = {
66
source = "hashicorp/aws"
7-
version = ">= 3.45"
7+
version = "~> 3.45"
88
}
99

1010
github = {

main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ data "aws_route53_zone" "this" {
131131
count = var.create_route53_record ? 1 : 0
132132

133133
name = var.route53_zone_name
134-
private_zone = false
134+
private_zone = var.route53_private_zone
135135
}
136136

137137
################################################################################

variables.tf

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,12 @@ variable "route53_record_name" {
224224
default = null
225225
}
226226

227+
variable "route53_private_zone" {
228+
description = "Enable to use a private Route53 zone"
229+
type = bool
230+
default = false
231+
}
232+
227233
variable "create_route53_record" {
228234
description = "Whether to create Route53 record for Atlantis"
229235
type = bool

versions.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ terraform {
44
required_providers {
55
aws = {
66
source = "hashicorp/aws"
7-
version = ">= 3.45"
7+
version = "~> 3.45"
88
}
99

1010
random = {

0 commit comments

Comments
 (0)