fix: Cannot specify more than one extra_container_definitions (#314)

Author: dynamike

README.md

@@ -367,7 +367,7 @@ allow_github_webhooks        = true
 | <a name="input_ephemeral_storage_size"></a> [ephemeral\_storage\_size](#input\_ephemeral\_storage\_size) | Size of Ephemeral Storage in GiB | `number` | `21` | no |
 | <a name="input_essential"></a> [essential](#input\_essential) | Determines whether all other containers in a task are stopped, if this container fails or stops for any reason. Due to how Terraform type casts booleans in json it is required to double quote this value | `bool` | `true` | no |
 | <a name="input_external_task_definition_updates"></a> [external\_task\_definition\_updates](#input\_external\_task\_definition\_updates) | Enable to allow the task definition to be updated outside of this Terraform module. This should be enabled when using a deployment tool such as ecs-deploy which updates the task definition and will then keep the ECS service using the latest version of the task definition. | `bool` | `false` | no |
-| <a name="input_extra_container_definitions"></a> [extra\_container\_definitions](#input\_extra\_container\_definitions) | A list of valid container definitions provided as a single valid JSON document. These will be provided as supplimentary to the main Atlantis container definition | `list(any)` | `[]` | no |
+| <a name="input_extra_container_definitions"></a> [extra\_container\_definitions](#input\_extra\_container\_definitions) | A list of valid container definitions provided as a single valid JSON document. These will be provided as supplimentary to the main Atlantis container definition | `any` | `[]` | no |
 | <a name="input_extra_load_balancers"></a> [extra\_load\_balancers](#input\_extra\_load\_balancers) | A list of maps for additional ECS task load balancers | `list(map(string))` | `[]` | no |
 | <a name="input_firelens_configuration"></a> [firelens\_configuration](#input\_firelens\_configuration) | The FireLens configuration for the container. This is used to specify and configure a log router for container logs. For more details, see https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_FirelensConfiguration.html | <pre>object({<br>    type    = string<br>    options = map(string)<br>  })</pre> | `null` | no |
 | <a name="input_github_webhooks_cidr_blocks"></a> [github\_webhooks\_cidr\_blocks](#input\_github\_webhooks\_cidr\_blocks) | List of IPv4 CIDR blocks used by GitHub webhooks | `list(string)` | <pre>[<br>  "140.82.112.0/20",<br>  "185.199.108.0/22",<br>  "192.30.252.0/22",<br>  "143.55.64.0/20"<br>]</pre> | no |

examples/github-complete/main.tf

@@ -99,6 +99,29 @@ module "atlantis" {
   allow_github_webhooks        = true
   allow_repo_config            = true
 
+  # Extra container definitions
+  extra_container_definitions = [
+    {
+      name      = "log-router"
+      image     = "amazon/aws-for-fluent-bit:latest"
+      essential = true
+
+      firelens_configuration = {
+        type = "fluentbit"
+
+        logConfiguration = {
+          logDriver = "awslogs",
+          options = {
+            awslogs-group         = "firelens-container",
+            awslogs-region        = local.region,
+            awslogs-create-group  = true,
+            awslogs-stream-prefix = "firelens"
+          }
+        }
+      }
+    }
+  ]
+
   tags = local.tags
 }
 

variables.tf

@@ -415,7 +415,7 @@ variable "custom_container_definitions" {
 
 variable "extra_container_definitions" {
   description = "A list of valid container definitions provided as a single valid JSON document. These will be provided as supplimentary to the main Atlantis container definition"
-  type        = list(any)
+  type        = any
   default     = []
 }