feat: Added IAM role id to outputs (#13)

Author: frimik

.pre-commit-config.yaml

@@ -1,10 +1,25 @@
 repos:
   - repo: git://github.com/antonbabenko/pre-commit-terraform
-    rev: v1.31.0
+    rev: v1.43.0
     hooks:
       - id: terraform_fmt
       - id: terraform_docs
+      - id: terraform_tflint
+        args:
+          - '--args=--only=terraform_deprecated_interpolation'
+          - '--args=--only=terraform_deprecated_index'
+          - '--args=--only=terraform_unused_declarations'
+          - '--args=--only=terraform_comment_syntax'
+          - '--args=--only=terraform_documented_outputs'
+          - '--args=--only=terraform_documented_variables'
+          - '--args=--only=terraform_typed_variables'
+          - '--args=--only=terraform_module_pinned_source'
+          - '--args=--only=terraform_naming_convention'
+          - '--args=--only=terraform_required_version'
+          - '--args=--only=terraform_required_providers'
+          - '--args=--only=terraform_standard_module_structure'
+          - '--args=--only=terraform_workspace_remote'
   - repo: git://github.com/pre-commit/pre-commit-hooks
-    rev: v3.1.0
+    rev: v3.2.0
     hooks:
       - id: check-merge-conflict

README.md

@@ -47,13 +47,16 @@ module "ecs" {
 <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
 ## Requirements
 
-No requirements.
+| Name | Version |
+|------|---------|
+| terraform | >= 0.12.6, < 0.14 |
+| aws | >= 2.0, < 4.0 |
 
 ## Providers
 
 | Name | Version |
 |------|---------|
-| aws | n/a |
+| aws | >= 2.0, < 4.0 |
 
 ## Inputs
 
@@ -68,8 +71,8 @@ No requirements.
 
 | Name | Description |
 |------|-------------|
-| this\_ecs\_cluster\_arn | n/a |
-| this\_ecs\_cluster\_id | n/a |
+| this\_ecs\_cluster\_arn | ARN of the ECS Cluster |
+| this\_ecs\_cluster\_id | ID of the ECS Cluster |
 | this\_ecs\_cluster\_name | The name of the ECS cluster |
 
 <!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

examples/complete-ecs/README.md

@@ -41,14 +41,18 @@ Current version creates an high-available VPC with instances that are attached t
 <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
 ## Requirements
 
-No requirements.
+| Name | Version |
+|------|---------|
+| terraform | >= 0.12.6, < 0.14 |
+| aws | >= 2.0, < 4.0 |
+| template | ~> 2.0 |
 
 ## Providers
 
 | Name | Version |
 |------|---------|
-| aws | n/a |
-| template | n/a |
+| aws | >= 2.0, < 4.0 |
+| template | ~> 2.0 |
 
 ## Inputs
 

examples/complete-ecs/main.tf

@@ -37,14 +37,14 @@ module "ecs" {
   container_insights = true
 }
 
-module "ec2-profile" {
+module "ec2_profile" {
   source = "../../modules/ecs-instance-profile"
   name   = local.name
 }
 
 #----- ECS  Services--------
 
-module "hello-world" {
+module "hello_world" {
   source     = "./service-hello-world"
   cluster_id = module.ecs.this_ecs_cluster_id
 }
@@ -80,16 +80,16 @@ module "this" {
   image_id             = data.aws_ami.amazon_linux_ecs.id
   instance_type        = "t2.micro"
   security_groups      = [module.vpc.default_security_group_id]
-  iam_instance_profile = module.ec2-profile.this_iam_instance_profile_id
+  iam_instance_profile = module.ec2_profile.this_iam_instance_profile_id
   user_data            = data.template_file.user_data.rendered
 
   # Auto scaling group
   asg_name                  = local.ec2_resources_name
   vpc_zone_identifier       = module.vpc.private_subnets
   health_check_type         = "EC2"
-  min_size                  = 1
+  min_size                  = 0
   max_size                  = 2
-  desired_capacity          = 1
+  desired_capacity          = 0
   wait_for_capacity_timeout = 0
 
   tags = [

examples/complete-ecs/outputs.tf

@@ -0,0 +1,7 @@
+terraform {
+  required_version = ">= 0.12.6, < 0.14"
+
+  required_providers {
+    aws = ">= 2.0, < 4.0"
+  }
+}

examples/complete-ecs/service-hello-world/outputs.tf

@@ -0,0 +1,8 @@
+terraform {
+  required_version = ">= 0.12.6, < 0.14"
+
+  required_providers {
+    aws      = ">= 2.0, < 4.0"
+    template = "~> 2.0"
+  }
+}

examples/complete-ecs/service-hello-world/versions.tf

@@ -28,6 +28,13 @@ resource "aws_iam_role_policy_attachment" "ecs_ec2_role" {
   policy_arn = "arn:aws:iam::aws:policy/service-role/AmazonEC2ContainerServiceforEC2Role"
 }
 
+resource "aws_iam_role_policy_attachment" "amazon_ssm_managed_instance_core" {
+  count = var.include_ssm ? 1 : 0
+
+  role       = aws_iam_role.this.id
+  policy_arn = "arn:aws:iam::aws:policy/AmazonSSMManagedInstanceCore"
+}
+
 resource "aws_iam_role_policy_attachment" "ecs_ec2_cloudwatch_role" {
   role       = aws_iam_role.this.id
   policy_arn = "arn:aws:iam::aws:policy/CloudWatchLogsFullAccess"