Skip to content

Commit 4046455

Browse files
Merge branch 'master' into aws-auth_enhancemnts
2 parents 6f886e6 + 75904e4 commit 4046455

File tree

6 files changed

+11
-4
lines changed

6 files changed

+11
-4
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ project adheres to [Semantic Versioning](http://semver.org/).
1616
### Added
1717

1818
- kubelet_node_labels worker group option allows setting --node-labels= in kubelet. (Hat-tip, @bshelton229 👒)
19+
- `worker_iam_role_arn` added to outputs. Sweet, @hatemosphere 🔥
1920

2021
### Changed
2122

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Read the [AWS docs on EKS to get connected to the k8s dashboard](https://docs.aw
1515
* You want to create an EKS cluster and an autoscaling group of workers for the cluster.
1616
* You want these resources to exist within security groups that allow communication and coordination. These can be user provided or created within the module.
1717
* You've created a Virtual Private Cloud (VPC) and subnets where you intend to put the EKS resources.
18-
* If using the default variable value (`true`) for `configure_kubectl_session`, it's required that both [`kubectl`](https://kubernetes.io/docs/tasks/tools/install-kubectl/#install-kubectl) (>=1.10) and [`heptio-authenticator-aws`](https://github.com/heptio/authenticator#4-set-up-kubectl-to-use-heptio-authenticator-for-aws-tokens) are installed and on your shell's PATH.
18+
* If using the default variable value (`true`) for `configure_kubectl_session`, it's required that both [`kubectl`](https://kubernetes.io/docs/tasks/tools/install-kubectl/#install-kubectl) (>=1.10) and [`aws-iam-authenticator`](https://github.com/kubernetes-sigs/aws-iam-authenticator#4-set-up-kubectl-to-use-authentication-tokens-provided-by-aws-iam-authenticator-for-kubernetes) are installed and on your shell's PATH.
1919

2020
## Usage example
2121

@@ -128,5 +128,6 @@ MIT Licensed. See [LICENSE](https://github.com/terraform-aws-modules/terraform-a
128128
| config_map_aws_auth | A kubernetes configuration to authenticate to this EKS cluster. |
129129
| kubeconfig | kubectl config file contents for this EKS cluster. |
130130
| worker_iam_role_name | IAM role name attached to EKS workers |
131+
| worker_iam_role_arn | IAM role ID attached to EKS workers |
131132
| worker_security_group_id | Security group ID attached to the EKS workers. |
132133
| workers_asg_arns | IDs of the autoscaling groups containing workers. |

aws_auth.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ resource "null_resource" "update_config_map_aws_auth" {
1313
config_map_rendered = "${data.template_file.config_map_aws_auth.rendered}"
1414
}
1515

16-
count = "${var.configure_kubectl_session ? 1 : 0}"
16+
count = "${var.manage_aws_auth ? 1 : 0}"
1717
}
1818

1919
data "template_file" "config_map_aws_auth" {

main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
** You want to create an EKS cluster and an autoscaling group of workers for the cluster.
1717
** You want these resources to exist within security groups that allow communication and coordination. These can be user provided or created within the module.
1818
** You've created a Virtual Private Cloud (VPC) and subnets where you intend to put the EKS resources.
19-
** If using the default variable value (`true`) for `configure_kubectl_session`, it's required that both [`kubectl`](https://kubernetes.io/docs/tasks/tools/install-kubectl/#install-kubectl) (>=1.10) and [`heptio-authenticator-aws`](https://github.com/heptio/authenticator#4-set-up-kubectl-to-use-heptio-authenticator-for-aws-tokens) are installed and on your shell's PATH.
19+
** If using the default variable value (`true`) for `configure_kubectl_session`, it's required that both [`kubectl`](https://kubernetes.io/docs/tasks/tools/install-kubectl/#install-kubectl) (>=1.10) and [`aws-iam-authenticator`](https://github.com/kubernetes-sigs/aws-iam-authenticator#4-set-up-kubectl-to-use-authentication-tokens-provided-by-aws-iam-authenticator-for-kubernetes) are installed and on your shell's PATH.
2020
2121
* ## Usage example
2222

outputs.tf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,3 +53,8 @@ output "worker_iam_role_name" {
5353
description = "IAM role name attached to EKS workers"
5454
value = "${aws_iam_role.workers.name}"
5555
}
56+
57+
output "worker_iam_role_arn" {
58+
description = "IAM role ID attached to EKS workers"
59+
value = "${aws_iam_role.workers.arn}"
60+
}

variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ variable "worker_sg_ingress_from_port" {
106106

107107
variable "kubeconfig_aws_authenticator_command" {
108108
description = "Command to use to to fetch AWS EKS credentials"
109-
default = "heptio-authenticator-aws"
109+
default = "aws-iam-authenticator"
110110
}
111111

112112
variable "kubeconfig_aws_authenticator_additional_args" {

0 commit comments

Comments
 (0)