fix: Remove data plane compute *_defaults variables that do not work with variable optional attributes

Author: bryantbiggs

README.md

@@ -54,12 +54,6 @@ module "eks" {
   create_security_group      = false
   create_node_security_group = false
 
-  fargate_profile_defaults = {
-    iam_role_additional_policies = {
-      additional = aws_iam_policy.additional.arn
-    }
-  }
-
   fargate_profiles = {
     example = {
       name = "example"
@@ -78,6 +72,10 @@ module "eks" {
         }
       ]
 
+      iam_role_additional_policies = {
+        additional = aws_iam_policy.additional.arn
+      }
+
       # Using specific subnets instead of the subnets supplied for the cluster itself
       subnet_ids = [module.vpc.private_subnets[1]]
 

node_groups.tf

@@ -87,11 +87,6 @@ module "eks" {
   subnet_ids               = module.vpc.private_subnets
   control_plane_subnet_ids = module.vpc.intra_subnets
 
-  eks_managed_node_group_defaults = {
-    ami_type       = "AL2023_x86_64_STANDARD"
-    instance_types = ["m6i.large", "m5.large", "m5n.large", "m5zn.large"]
-  }
-
   eks_managed_node_groups = {
     # Default node group - as provided by AWS EKS
     default_node_group = {

tests/eks-fargate-profile/main.tf

@@ -70,20 +70,18 @@ module "eks" {
     provider_key_arn = module.kms.key_arn
   }
 
-  self_managed_node_group_defaults = {
-    ami_type = "AL2023_x86_64_STANDARD"
-    ami_id   = data.aws_ami.eks_default.image_id
-
-    # enable discovery of autoscaling groups by cluster-autoscaler
-    autoscaling_group_tags = {
-      "k8s.io/cluster-autoscaler/enabled" : true,
-      "k8s.io/cluster-autoscaler/${local.name}" : "owned",
-    }
-  }
-
   self_managed_node_groups = {
     # Default node group - as provisioned by the module defaults
-    default_node_group = {}
+    default_node_group = {
+      ami_type = "AL2023_x86_64_STANDARD"
+      ami_id   = data.aws_ami.eks_default.image_id
+
+      # enable discovery of autoscaling groups by cluster-autoscaler
+      autoscaling_group_tags = {
+        "k8s.io/cluster-autoscaler/enabled" : true,
+        "k8s.io/cluster-autoscaler/${local.name}" : "owned",
+      }
+    }
 
     # Bottlerocket node group
     bottlerocket = {