Skip to content

Commit f083816

Browse files
Fix annoying typo: worker_group_xx vs worker_groups_xx (#374)
1 parent f155e40 commit f083816

File tree

6 files changed

+57
-51
lines changed

6 files changed

+57
-51
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,12 @@ project adheres to [Semantic Versioning](http://semver.org/).
1919

2020
# History
2121

22+
## [[v4.0.1](https://github.com/terraform-aws-modules/terraform-aws-eks/compare/v4.0.0...v4.0.1)] - 2019-05-07]
23+
24+
### Changed
25+
26+
- Fix annoying typo: worker_group_xx vs worker_groups_xx (by @max-rocket-internet)
27+
2228
## [[v4.0.0](https://github.com/terraform-aws-modules/terraform-aws-eks/compare/v3.0.0...v4.0.0)] - 2019-05-07]
2329

2430
### Added

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,11 +148,11 @@ MIT Licensed. See [LICENSE](https://github.com/terraform-aws-modules/terraform-a
148148
| worker\_create\_security\_group | Whether to create a security group for the workers or attach the workers to `worker_security_group_id`. | string | `"true"` | no |
149149
| worker\_group\_count | The number of maps contained within the worker_groups list. | string | `"1"` | no |
150150
| worker\_group\_launch\_template\_count | The number of maps contained within the worker_groups_launch_template list. | string | `"0"` | no |
151-
| worker\_group\_launch\_template\_mixed | A list of maps defining worker group configurations to be defined using AWS Launch Templates. See workers_group_defaults for valid keys. | list | `[ { "name": "default" } ]` | no |
152-
| worker\_group\_launch\_template\_mixed\_count | The number of maps contained within the worker_group_launch_template_mixed list. | string | `"0"` | no |
151+
| worker\_group\_launch\_template\_mixed\_count | The number of maps contained within the worker_groups_launch_template_mixed list. | string | `"0"` | no |
153152
| worker\_group\_tags | A map defining extra tags to be applied to the worker group ASG. | map | `{ "default": [] }` | no |
154153
| worker\_groups | A list of maps defining worker group configurations to be defined using AWS Launch Configurations. See workers_group_defaults for valid keys. | list | `[ { "name": "default" } ]` | no |
155154
| worker\_groups\_launch\_template | A list of maps defining worker group configurations to be defined using AWS Launch Templates. See workers_group_defaults for valid keys. | list | `[ { "name": "default" } ]` | no |
155+
| worker\_groups\_launch\_template\_mixed | A list of maps defining worker group configurations to be defined using AWS Launch Templates. See workers_group_defaults for valid keys. | list | `[ { "name": "default" } ]` | no |
156156
| worker\_security\_group\_id | If provided, all workers will be attached to this security group. If not given, a security group will be created with necessary ingres/egress to work with the EKS cluster. | string | `""` | no |
157157
| worker\_sg\_ingress\_from\_port | Minimum port number from which pods will accept communication. Must be changed to a lower value if some pods in your cluster will expose a port lower than 1025 (e.g. 22, 80, or 443). | string | `"1025"` | no |
158158
| workers\_additional\_policies | Additional policies to be added to workers | list | `[]` | no |

data.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,5 +133,5 @@ data "aws_iam_instance_profile" "custom_worker_group_launch_template_iam_instanc
133133

134134
data "aws_iam_instance_profile" "custom_worker_group_launch_template_mixed_iam_instance_profile" {
135135
count = "${var.manage_worker_iam_resources ? 0 : var.worker_group_launch_template_mixed_count}"
136-
name = "${lookup(var.worker_group_launch_template_mixed[count.index], "iam_instance_profile_name", local.workers_group_defaults["iam_instance_profile_name"])}"
136+
name = "${lookup(var.worker_groups_launch_template_mixed[count.index], "iam_instance_profile_name", local.workers_group_defaults["iam_instance_profile_name"])}"
137137
}

variables.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ variable "worker_groups_launch_template" {
132132
]
133133
}
134134

135-
variable "worker_group_launch_template_mixed" {
135+
variable "worker_groups_launch_template_mixed" {
136136
description = "A list of maps defining worker group configurations to be defined using AWS Launch Templates. See workers_group_defaults for valid keys."
137137
type = "list"
138138

@@ -144,7 +144,7 @@ variable "worker_group_launch_template_mixed" {
144144
}
145145

146146
variable "worker_group_launch_template_mixed_count" {
147-
description = "The number of maps contained within the worker_group_launch_template_mixed list."
147+
description = "The number of maps contained within the worker_groups_launch_template_mixed list."
148148
type = "string"
149149
default = "0"
150150
}

version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v4.0.0
1+
v4.0.1

0 commit comments

Comments
 (0)