20.31.5 broken

[zachvida]

Description

�Terraform v1.6.4
on linux_amd64
Initializing plugins and modules...
module.eks.aws_eks_cluster.this[0]: Modifying... [id=cluster-dev]
╷
│ Error: updating EKS Cluster (cluster-dev) compute config: operation error EKS: UpdateClusterConfig, https response error StatusCode: 400, RequestID: XXXXX, InvalidParameterException: The type for cluster update was not provided.
│
│ with module.eks.aws_eks_cluster.this[0],
│ on .terraform/modules/eks/main.tf line 35, in resource "aws_eks_cluster" "this":
│ 35: resource "aws_eks_cluster" "this" {
│

I believe this is related to the fact that govcloud does not support the automode features yet.

Operation failed: failed running terraform apply (exit 1)

• [x ] ✋ I have searched the open/closed issues and my issue is not listed.

Cloudtail logs snippet:
errorCode: InvalidParameterException
eventName: UpdateClusterConfig
eventSource: eks.amazonaws.com
requestParameters": {"clientRequestToken": "33333", "storageConfig": {"blockStorage": {"enabled": false}}, "name": "cluster-dev", "kubernetesNetworkConfig": {"elasticLoadBalancing": {"enabled": false}, "ipFamily": "ipv4", "serviceIpv4Cidr": "172.20.0.0/16"}}, "responseElements": {"message": "The type for cluster update was not provided."}

Versions

• Module version [Required]: 20.31.5 reversion to 20.31.1 works

• Terraform version:
  1.6.4

• Provider version(s):
  5.82.0

[waitstime]

Looks like it was broken by #3253

[davekonopka]

We're hitting an error during apply on AWS commercial related to the storage change linked above for existing clusters managed with the module:

│ Error: updating EKS Cluster (...) compute config: operation error EKS: UpdateClusterConfig, https response error StatusCode: 400, RequestID: ..., InvalidParameterException: The type for cluster update was not provided.

It wants to add the storage_config block to the cluster:

      + storage_config {
          + block_storage {
              + enabled = false
            }
        }

[kian]

Ran into this as well (AWS commercial; it's not GovCloud-specific). The issue appears to be that compute_config must be disabled when not using Auto Mode.

20.31.5 aims to fix this, but I think compute_config with enabled = false does not get created when cluster_compute_config is not set by module users.

I worked around it by being explicit when invoking the module:

module "eks" {
  ...
  cluster_compute_config = {
    enabled = false
  }
}

[zachvida]

updated the issue title to relfect not just govcloud

[bdandoy]

We are having the same issue @bryantbiggs can you help?

[bryantbiggs]

oy, this API shape across 3 attribute is quite problematic. I think the only course is to revert the prior change

[antonbabenko]

This issue has been resolved in version 20.31.6 🎉

[moore-nathan]

I'll ask here first before making a new issue, but does the revert mean that the reverse of this is broken?
I get a compute config: operation error EKS: UpdateClusterConfig, https response error StatusCode: 400, RequestID: xxx, InvalidParameterException: The type for cluster update was not provided. when trying to explicitly set it to false. (This is for an already existing cluster)

cluster_compute_config =  {
    enabled       =  false
    node_pools = ["general-purpose", "system"]
}

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.