Skip to content

Conversation

@jkt-signal
Copy link

Description

Adds an output to the eks-managed-node-group module with the release version used for the node group.

Motivation and Context

The release version being used (when not supplied from the outside with the ami_release_version or ami_id variables) is only available in a resource and locals private to this module. Users of the module can therefore not determine what AMI release version is being used if they use use_latest_ami_release_version; this change adds an output with that information, which makes it possible for users of the module to determine whether an update is happening (by comparing to an aws_eks_managed_node_group data resource, for example).

Breaking Changes

No, this only adds an output and makes no breaking changes.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects

The existing examples/eks-managed-node-group applies with no changes in the plan after this commit. The examples do not seem to include examples of using the outputs of the module, and I did not add one.

  • I have executed pre-commit run -a on my pull request

This makes it possible for users of the module to determine whether an update
is happening (by comparing to an `aws_eks_managed_node_group` data resource,
for example).
@bryantbiggs
Copy link
Member

I don't see why this is useful, could you elaborate? if you want to know the release version used by a node group, you can look in the console or use the API https://docs.aws.amazon.com/cli/latest/reference/eks/describe-nodegroup.html

@bryantbiggs
Copy link
Member

going to close this for now since I don't think we need to continue to expand the surface are of inputs/outputs for things like this

@jkt-signal
Copy link
Author

I don't see why this is useful, could you elaborate? if you want to know the release version used by a node group, you can look in the console or use the API https://docs.aws.amazon.com/cli/latest/reference/eks/describe-nodegroup.html

This isn't for looking at the version manually; I'd like to use it to set up a Terraform precondition block to require manual confirmation if a terraform apply is about to upgrade the Kubernetes version on our managed node groups.

@bryantbiggs
Copy link
Member

that still doesn't make sense. you can set the Kubernetes version that should be used by the node group and control when and to what version it is upgraded

@jkt-signal
Copy link
Author

Sorry, that was a typo; we do fix the Kubernetes version, I meant the AMI version.

@bryantbiggs
Copy link
Member

still not following - we support tracking latest, otherwise you can specify the AMI version if you'd like. nothing to do with outputs

@github-actions
Copy link

github-actions bot commented Feb 7, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants