From 5c843bef2be33284f817d9c75319c7115bb9151b Mon Sep 17 00:00:00 2001 From: Kamontat Chantrachirathumrong <14089557+kamontat@users.noreply.github.com> Date: Mon, 25 Aug 2025 17:58:28 +0700 Subject: [PATCH 1/2] fix(module): wrong variable name in eks-managed-node-group --- modules/eks-managed-node-group/main.tf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/eks-managed-node-group/main.tf b/modules/eks-managed-node-group/main.tf index 85d75efece..0e34b45453 100644 --- a/modules/eks-managed-node-group/main.tf +++ b/modules/eks-managed-node-group/main.tf @@ -315,7 +315,7 @@ resource "aws_launch_template" "this" { primary_ipv6 = network_interfaces.value.primary_ipv6 private_ip_address = network_interfaces.value.private_ip_address # Ref: https://github.com/hashicorp/terraform-provider-aws/issues/4570 - security_groups = compact(concat(network_interfaces.value.security_groups, var.vpc_security_group_ids)) + security_groups = compact(concat(network_interfaces.value.security_groups, local.security_group_ids)) # Set on EKS managed node group, will fail if set here # https://docs.aws.amazon.com/eks/latest/userguide/launch-templates.html#launch-template-basics # subnet_id = try(network_interfaces.value.subnet_id, null) @@ -360,7 +360,7 @@ resource "aws_launch_template" "this" { update_default_version = var.update_launch_template_default_version user_data = module.user_data.user_data - vpc_security_group_ids = length(local.network_interfaces) > 0 ? [] : local.security_group_ids + vpc_security_group_ids = length(local.network_interfaces) > 0 ? [] : var.vpc_security_group_ids tags = merge( var.tags, From 822a92d8f17267401e4b0061edacd239ca52fb5c Mon Sep 17 00:00:00 2001 From: Bryant Biggs Date: Mon, 25 Aug 2025 13:17:21 -0500 Subject: [PATCH 2/2] Update modules/eks-managed-node-group/main.tf --- modules/eks-managed-node-group/main.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/eks-managed-node-group/main.tf b/modules/eks-managed-node-group/main.tf index 0e34b45453..fa940c51a9 100644 --- a/modules/eks-managed-node-group/main.tf +++ b/modules/eks-managed-node-group/main.tf @@ -360,7 +360,7 @@ resource "aws_launch_template" "this" { update_default_version = var.update_launch_template_default_version user_data = module.user_data.user_data - vpc_security_group_ids = length(local.network_interfaces) > 0 ? [] : var.vpc_security_group_ids + vpc_security_group_ids = length(local.network_interfaces) > 0 ? [] : local.security_group_ids tags = merge( var.tags,