feat: Add name_prefix to iam-policy and iam-read-only-policy modules (#369)

Co-authored-by: magreenbaum <magreenbaum>

Author: magreenbaum

examples/iam-policy/main.tf

@@ -16,7 +16,7 @@ data "aws_iam_policy_document" "bucket_policy" {
 module "iam_policy" {
   source = "../../modules/iam-policy"
 
-  name        = "example"
+  name_prefix = "example-"
   path        = "/"
   description = "My example policy"
 

modules/iam-policy/README.md

@@ -32,7 +32,8 @@ No modules.
 |------|-------------|------|---------|:--------:|
 | <a name="input_create_policy"></a> [create\_policy](#input\_create\_policy) | Whether to create the IAM policy | `bool` | `true` | no |
 | <a name="input_description"></a> [description](#input\_description) | The description of the policy | `string` | `"IAM Policy"` | no |
-| <a name="input_name"></a> [name](#input\_name) | The name of the policy | `string` | `""` | no |
+| <a name="input_name"></a> [name](#input\_name) | The name of the policy | `string` | `null` | no |
+| <a name="input_name_prefix"></a> [name\_prefix](#input\_name\_prefix) | IAM policy name prefix | `string` | `null` | no |
 | <a name="input_path"></a> [path](#input\_path) | The path of the policy in IAM | `string` | `"/"` | no |
 | <a name="input_policy"></a> [policy](#input\_policy) | The path of the policy in IAM (tpl file) | `string` | `""` | no |
 | <a name="input_tags"></a> [tags](#input\_tags) | A map of tags to add to all resources. | `map(string)` | `{}` | no |

modules/iam-policy/main.tf

@@ -2,6 +2,7 @@ resource "aws_iam_policy" "policy" {
   count = var.create_policy ? 1 : 0
 
   name        = var.name
+  name_prefix = var.name_prefix
   path        = var.path
   description = var.description
 

modules/iam-policy/variables.tf

@@ -7,7 +7,13 @@ variable "create_policy" {
 variable "name" {
   description = "The name of the policy"
   type        = string
-  default     = ""
+  default     = null
+}
+
+variable "name_prefix" {
+  description = "IAM policy name prefix"
+  type        = string
+  default     = null
 }
 
 variable "path" {

modules/iam-read-only-policy/README.md

@@ -43,7 +43,8 @@ No modules.
 | <a name="input_allowed_services"></a> [allowed\_services](#input\_allowed\_services) | List of services to allow Get/List/Describe/View options. Service name should be the same as corresponding service IAM prefix. See what it is for each service here https://docs.aws.amazon.com/service-authorization/latest/reference/reference_policies_actions-resources-contextkeys.html | `list(string)` | n/a | yes |
 | <a name="input_create_policy"></a> [create\_policy](#input\_create\_policy) | Whether to create the IAM policy | `bool` | `true` | no |
 | <a name="input_description"></a> [description](#input\_description) | The description of the policy | `string` | `"IAM Policy"` | no |
-| <a name="input_name"></a> [name](#input\_name) | The name of the policy | `string` | `""` | no |
+| <a name="input_name"></a> [name](#input\_name) | The name of the policy | `string` | `null` | no |
+| <a name="input_name_prefix"></a> [name\_prefix](#input\_name\_prefix) | IAM policy name prefix | `string` | `null` | no |
 | <a name="input_path"></a> [path](#input\_path) | The path of the policy in IAM | `string` | `"/"` | no |
 | <a name="input_tags"></a> [tags](#input\_tags) | A map of tags to add to all resources. | `map(string)` | `{}` | no |
 | <a name="input_web_console_services"></a> [web\_console\_services](#input\_web\_console\_services) | List of web console services to allow | `list(string)` | <pre>[<br>  "resource-groups",<br>  "tag",<br>  "health",<br>  "ce"<br>]</pre> | no |

modules/iam-read-only-policy/main.tf

@@ -2,6 +2,7 @@ resource "aws_iam_policy" "policy" {
   count = var.create_policy ? 1 : 0
 
   name        = var.name
+  name_prefix = var.name_prefix
   path        = var.path
   description = var.description
 

modules/iam-read-only-policy/variables.tf

@@ -7,7 +7,13 @@ variable "create_policy" {
 variable "name" {
   description = "The name of the policy"
   type        = string
-  default     = ""
+  default     = null
+}
+
+variable "name_prefix" {
+  description = "IAM policy name prefix"
+  type        = string
+  default     = null
 }
 
 variable "path" {