fix: Skip retrieving EKS cluster data when not creating the role (#436)

wonko · antonbabenko · bryantbiggs · web-flow · commit bcdf554783c0 · 2024-01-17T20:23:28.000-05:00
Co-authored-by: Anton Babenko &lt;anton@antonbabenko.com&gt;
Co-authored-by: Bryant Biggs &lt;bryantbiggs@gmail.com&gt;
diff --git a/modules/iam-eks-role/main.tf b/modules/iam-eks-role/main.tf
@@ -8,7 +8,7 @@ locals {
 }
 
 data "aws_eks_cluster" "main" {
-  for_each = var.cluster_service_accounts
+  for_each = { for k, v in var.cluster_service_accounts : k => v if var.create_role }
 
   name = each.key
 }
@@ -37,7 +37,7 @@ data "aws_iam_policy_document" "assume_role_with_oidc" {
   }
 
   dynamic "statement" {
-    for_each = var.cluster_service_accounts
+    for_each = { for k, v in var.cluster_service_accounts : k => v if var.create_role }
 
     content {
       effect  = "Allow"

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ locals {`
`8`	`8`	`}`
`9`	`9`
`10`	`10`	`data "aws_eks_cluster" "main" {`
`11`		`- for_each = var.cluster_service_accounts`
	`11`	`+ for_each = { for k, v in var.cluster_service_accounts : k => v if var.create_role }`
`12`	`12`
`13`	`13`	`name = each.key`
`14`	`14`	`}`
`@@ -37,7 +37,7 @@ data "aws_iam_policy_document" "assume_role_with_oidc" {`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`dynamic "statement" {`
`40`		`- for_each = var.cluster_service_accounts`
	`40`	`+ for_each = { for k, v in var.cluster_service_accounts : k => v if var.create_role }`
`41`	`41`
`42`	`42`	`content {`
`43`	`43`	`effect = "Allow"`