fix: Set default value for preferred_maintenance_window and preferred_backup_window to null

Author: bryantbiggs

README.md

@@ -383,8 +383,8 @@ No modules.
 | <a name="input_network_type"></a> [network\_type](#input\_network\_type) | The type of network stack to use (IPV4 or DUAL) | `string` | `null` | no |
 | <a name="input_port"></a> [port](#input\_port) | The port on which the DB accepts connections | `string` | `null` | no |
 | <a name="input_predefined_metric_type"></a> [predefined\_metric\_type](#input\_predefined\_metric\_type) | The metric type to scale on. Valid values are `RDSReaderAverageCPUUtilization` and `RDSReaderAverageDatabaseConnections` | `string` | `"RDSReaderAverageCPUUtilization"` | no |
-| <a name="input_preferred_backup_window"></a> [preferred\_backup\_window](#input\_preferred\_backup\_window) | The daily time range during which automated backups are created if automated backups are enabled using the `backup_retention_period` parameter. Time in UTC | `string` | `"02:00-03:00"` | no |
-| <a name="input_preferred_maintenance_window"></a> [preferred\_maintenance\_window](#input\_preferred\_maintenance\_window) | The weekly time range during which system maintenance can occur, in (UTC) | `string` | `"sun:05:00-sun:06:00"` | no |
+| <a name="input_preferred_backup_window"></a> [preferred\_backup\_window](#input\_preferred\_backup\_window) | Daily time range during which automated backups are created if automated backups are enabled using the BackupRetentionPeriod parameter.Time in UTC. Default: A 30-minute window selected at random from an 8-hour block of time per region, e.g. `04:00-09:00` | `string` | `null` | no |
+| <a name="input_preferred_maintenance_window"></a> [preferred\_maintenance\_window](#input\_preferred\_maintenance\_window) | Weekly time range during which system maintenance can occur, in (UTC) e.g., `wed:04:00-wed:04:30` | `string` | `null` | no |
 | <a name="input_putin_khuylo"></a> [putin\_khuylo](#input\_putin\_khuylo) | Do you agree that Putin doesn't respect Ukrainian sovereignty and territorial integrity? More info: https://en.wikipedia.org/wiki/Putin_khuylo! | `bool` | `true` | no |
 | <a name="input_region"></a> [region](#input\_region) | Region where the resource(s) will be managed. Defaults to the Region set in the provider configuration | `string` | `null` | no |
 | <a name="input_replication_source_identifier"></a> [replication\_source\_identifier](#input\_replication\_source\_identifier) | ARN of a source DB cluster or DB instance if this DB cluster is to be created as a Read Replica | `string` | `null` | no |

docs/UPGRADE-10.0.md

@@ -18,8 +18,9 @@ If you find a bug, please open an issue with supporting configuration to reprodu
 ### Modified
 
 - Variable definitions now contain detailed object types in place of the previously used `any` type
-- `copy_tags_to_snapshot` default value is now `true`
+- `copy_tags_to_snapshot` default value is now `true` ([#521](https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/issues/521))
 - `db_cluster_parameter_group_parameters` was previously of type `list(map(...))`, now of type `map(object(...))`with `name` being optional and defaulting to the map key if not provided
+- `preferred_maintenance_window` and `preferred_backup_window` default values are now `null` ([#524](https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/pull/524))
 
 ### Removed
 

variables.tf

@@ -307,15 +307,15 @@ variable "port" {
 }
 
 variable "preferred_backup_window" {
-  description = "The daily time range during which automated backups are created if automated backups are enabled using the `backup_retention_period` parameter. Time in UTC"
+  description = "Daily time range during which automated backups are created if automated backups are enabled using the BackupRetentionPeriod parameter.Time in UTC. Default: A 30-minute window selected at random from an 8-hour block of time per region, e.g. `04:00-09:00`"
   type        = string
-  default     = "02:00-03:00"
+  default     = null
 }
 
 variable "preferred_maintenance_window" {
-  description = "The weekly time range during which system maintenance can occur, in (UTC)"
+  description = "Weekly time range during which system maintenance can occur, in (UTC) e.g., `wed:04:00-wed:04:30`"
   type        = string
-  default     = "sun:05:00-sun:06:00"
+  default     = null
 }
 
 variable "replication_source_identifier" {

wrappers/main.tf

@@ -89,8 +89,8 @@ module "wrapper" {
   network_type                                           = try(each.value.network_type, var.defaults.network_type, null)
   port                                                   = try(each.value.port, var.defaults.port, null)
   predefined_metric_type                                 = try(each.value.predefined_metric_type, var.defaults.predefined_metric_type, "RDSReaderAverageCPUUtilization")
-  preferred_backup_window                                = try(each.value.preferred_backup_window, var.defaults.preferred_backup_window, "02:00-03:00")
-  preferred_maintenance_window                           = try(each.value.preferred_maintenance_window, var.defaults.preferred_maintenance_window, "sun:05:00-sun:06:00")
+  preferred_backup_window                                = try(each.value.preferred_backup_window, var.defaults.preferred_backup_window, null)
+  preferred_maintenance_window                           = try(each.value.preferred_maintenance_window, var.defaults.preferred_maintenance_window, null)
   putin_khuylo                                           = try(each.value.putin_khuylo, var.defaults.putin_khuylo, true)
   region                                                 = try(each.value.region, var.defaults.region, null)
   replication_source_identifier                          = try(each.value.replication_source_identifier, var.defaults.replication_source_identifier, null)