Skip to content

docs: Update serverless configuration types to be more specifc about available options #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: Update serverless configuration types to be more specifc about available options #486

wants to merge 1 commit into from

Conversation

jeknom
Copy link

@jeknom jeknom commented Feb 14, 2025

Description

Updated the variable types on serverless scaling configurations so that you can easily see all the available options.

Motivation and Context

When working with this module, I had to jump between different documentation pages to find out what is actually available. I think this might make it a bit easier in the future.

Breaking Changes

I don't think this breaks anything, unless someone is providing values into the config that are not available anyway. And I guess you would get an error in that case anyway.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs
Copy link
Member

Requires a minimum version of Terraform 1.3.0 - https://github.com/hashicorp/terraform/blob/v1.3/CHANGELOG.md#130-september-21-2022

this would be a breaking change which we are not going to perform at this time

@jeknom
Copy link
Author

jeknom commented Feb 14, 2025 •
edited
Loading

Requires a minimum version of Terraform 1.3.0 - https://github.com/hashicorp/terraform/blob/v1.3/CHANGELOG.md#130-september-21-2022

this would be a breaking change which we are not going to perform at this time

Good to know, thank you for the reply 👍

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeknom @bryantbiggs