Remove Deprecated configuration from aws_s3_bucket resource

[nronix]

Description

object_lock_enabled is deprecated https://registry.terraform.io/providers/-/aws/6.33.0/docs/resources/s3_bucket
Latest version of module must remove the usage of object_lock_enabled inside aws_s3_bucket.
Just commenting it would help and it will not break any usage. people can continue to use var.object_lock_enabled to enable to disable the object lock. As per AWS document object lock cannot be disabled but default retention period can be disabled. This would mimic the AWS behaviour and prevent the deletion of s3 bucket in case user choose to update var object_lock_enabled = false / true

If your request is for a new feature, please use the Feature request template.

• ✋ I have searched the open/closed issues and my issue is not listed.

⚠️ Note

Before you submit an issue, please perform the following first:

1. Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
2. Re-initialize the project root to pull down modules: terraform init
3. Re-attempt your terraform plan or apply and check if the issue still persists

Versions

• Module version [Required]:

• Terraform version:

• Provider version(s):

Reproduction Code [Required]

Steps to reproduce the behavior:

Expected behavior

Actual behavior

Terminal Output Screenshot(s)

Additional context

[nronix]

@mbainter @pselle @matsev @antonbabenko can anyone please take a look at this

[bryantbiggs]

please don't spam people over a simple deprecation - its just a warning, no immediate action and it will be resolved at the next breaking change