Fix creating nat gw aws_route_table_association's when enable_nat_gateway=false

kkonstant-in · web-flow · commit 1c8cc62c2b3c · 2024-06-06T11:07:40.000+12:00
Fixes the issue described #1031
diff --git a/main.tf b/main.tf
@@ -277,7 +277,7 @@ resource "aws_route_table" "private" {
 }
 
 resource "aws_route_table_association" "private" {
-  count = local.create_private_subnets ? local.len_private_subnets : 0
+  count = local.create_private_subnets && var.enable_nat_gateway ? local.len_private_subnets : 0
 
   subnet_id = element(aws_subnet.private[*].id, count.index)
   route_table_id = element(
@@ -411,7 +411,7 @@ resource "aws_route_table" "database" {
 }
 
 resource "aws_route_table_association" "database" {
-  count = local.create_database_subnets ? local.len_database_subnets : 0
+  count = local.create_database_subnets && var.enable_nat_gateway ? local.len_database_subnets : 0
 
   subnet_id = element(aws_subnet.database[*].id, count.index)
   route_table_id = element(
@@ -723,7 +723,7 @@ resource "aws_route_table" "elasticache" {
 }
 
 resource "aws_route_table_association" "elasticache" {
-  count = local.create_elasticache_subnets ? local.len_elasticache_subnets : 0
+  count = local.create_elasticache_subnets && var.enable_nat_gateway ? local.len_elasticache_subnets : 0
 
   subnet_id = element(aws_subnet.elasticache[*].id, count.index)
   route_table_id = element(

Original file line number	Diff line number	Diff line change
`@@ -277,7 +277,7 @@ resource "aws_route_table" "private" {`
`277`	`277`	`}`
`278`	`278`
`279`	`279`	`resource "aws_route_table_association" "private" {`
`280`		`- count = local.create_private_subnets ? local.len_private_subnets : 0`
	`280`	`+ count = local.create_private_subnets && var.enable_nat_gateway ? local.len_private_subnets : 0`
`281`	`281`
`282`	`282`	`subnet_id = element(aws_subnet.private[*].id, count.index)`
`283`	`283`	`route_table_id = element(`
`@@ -411,7 +411,7 @@ resource "aws_route_table" "database" {`
`411`	`411`	`}`
`412`	`412`
`413`	`413`	`resource "aws_route_table_association" "database" {`
`414`		`- count = local.create_database_subnets ? local.len_database_subnets : 0`
	`414`	`+ count = local.create_database_subnets && var.enable_nat_gateway ? local.len_database_subnets : 0`
`415`	`415`
`416`	`416`	`subnet_id = element(aws_subnet.database[*].id, count.index)`
`417`	`417`	`route_table_id = element(`
`@@ -723,7 +723,7 @@ resource "aws_route_table" "elasticache" {`
`723`	`723`	`}`
`724`	`724`
`725`	`725`	`resource "aws_route_table_association" "elasticache" {`
`726`		`- count = local.create_elasticache_subnets ? local.len_elasticache_subnets : 0`
	`726`	`+ count = local.create_elasticache_subnets && var.enable_nat_gateway ? local.len_elasticache_subnets : 0`
`727`	`727`
`728`	`728`	`subnet_id = element(aws_subnet.elasticache[*].id, count.index)`
`729`	`729`	`route_table_id = element(`