Mark all child module variables with defaults as nullable=false so defaults are applied correctly

Author: cgascoig

modules/cluster/variables.tf

@@ -33,16 +33,19 @@ variable "wait_for_completion" {
   type        = bool
   default     = false
   description = "Wait for cluster completion true/false"
+  nullable    = false
 }
 variable "runtime_policy_moid" {
   type        = string
   description = "MOID for the Runtime Policy that is being consumed."
   default     = ""
+  nullable    = false
 }
 variable "trusted_registry_policy_moid" {
   type        = string
   description = "MOID for the Trusted Registry Policy that is being consumed."
   default     = ""
+  nullable    = false
 }
 
 variable "net_config_moid" {
@@ -60,6 +63,7 @@ variable "action" {
   type        = string
   description = "Action for cluster. i.e 'Deploy' 'Unassign'"
   default     = "Unassign"
+  nullable    = false
 }
 
 

modules/cluster_addon_profile/variables.tf

@@ -22,6 +22,7 @@ variable "cluster_moid" {
   type        = string
   description = "MOID of the cluster to be associated with this cluster addon profile."
   default     = ""
+  nullable    = false
 }
 variable "org_name" {
   type        = string

modules/infra_provider/variables.tf

@@ -6,21 +6,25 @@ variable "description" {
   type        = string
   default     = ""
   description = "Description to be used to describe the infrastructure provider policy"
+  nullable    = false
 }
 variable "instance_type_moid" {
   type        = string
   description = "MOID of the Instance type mapped to this provider"
   default     = ""
+  nullable    = false
 }
 variable "node_group_moid" {
   type        = string
   description = "MOID of the Node Group mapped to this provider"
   default     = ""
+  nullable    = false
 }
 variable "infra_config_policy_moid" {
   type        = string
   description = "MOID of the Infra Config Policy mapped to this provider"
   default     = ""
+  nullable    = false
 }
 variable "tags" {
   type        = list(map(string))

modules/ip_pool/variables.tf

@@ -6,6 +6,7 @@ variable "description" {
   type        = string
   default     = ""
   description = "Description to be used to describe the IP Pool Policy."
+  nullable    = false
 }
 variable "name" {
   type        = string
@@ -35,6 +36,7 @@ variable "secondary_dns" {
   type        = string
   description = "Secondary DNS Server for this pool."
   default     = ""
+  nullable    = false
 }
 
 variable "tags" {

modules/k8s_network/variables.tf

@@ -15,16 +15,19 @@ variable "pod_cidr" {
   type        = string
   description = "Pod CIDR Block to be used to assign POD IP Addresses."
   default     = "100.65.0.0/16"
+  nullable    = false
 }
 variable "service_cidr" {
   type        = string
   description = "Service CIDR Block used to assign cluster service IP addresses."
   default     = "100.64.0.0/24"
+  nullable    = false
 }
 variable "cni" {
   type        = string
   description = "Supported CNI type. Currently we only support Calico.* Calico - Calico CNI plugin as described in https://github.com/projectcalico/cni-plugin."
   default     = "Calico"
+  nullable    = false
 }
 
 variable "tags" {

modules/k8s_sysconfig/variables.tf

@@ -6,6 +6,7 @@ variable "description" {
   type        = string
   default     = ""
   description = "Description to be used to describe the K8s sysconfig profile."
+  nullable    = false
 }
 variable "policy_name" {
   type        = string

modules/node_profile/variables.tf

@@ -6,16 +6,19 @@ variable "description" {
   type        = string
   description = "Descripton of the Node Profile."
   default     = ""
+  nullable    = false
 }
 variable "action" {
   default     = "No-op"
   description = "User Initiated action.  Options are {{Delete|Deploy|Ready|No-op|Unassign}."
   type        = string
+  nullable    = false
 }
 variable "profile_type" {
   type        = string
   description = "Type of profile to be created. i.e Master or Worker"
   default     = ""
+  nullable    = false
 }
 variable "min_size" {
   type        = number

modules/runtime_policy/variables.tf

@@ -10,11 +10,13 @@ variable "description" {
   type        = string
   default     = ""
   description = "Description to be used to describe the addon policy"
+  nullable    = false
 }
 variable "docker_bridge_cidr" {
   type        = string
   default     = ""
   description = "Docker Bridge CIDR network to be specified."
+  nullable    = false
 }
 variable "proxy_http_hostname" {
   type        = string
@@ -24,21 +26,25 @@ variable "proxy_http_password" {
   type        = string
   default     = ""
   description = "The password for the HTTP Proxy."
+  nullable    = false
 }
 variable "proxy_http_username" {
   type        = string
   default     = ""
   description = "The username for the HTTP Proxy."
+  nullable    = false
 }
 variable "proxy_http_port" {
   type        = number
   default     = 8080
   description = "The HTTP Proxy port number.The port number of the HTTP proxy must be between 1 and 65535, inclusive."
+  nullable    = false
 }
 variable "proxy_http_protocol" {
   type        = string
   default     = "http"
   description = " Protocol to use for the HTTPS Proxy."
+  nullable    = false
 }
 variable "proxy_https_hostname" {
   type        = string
@@ -48,26 +54,31 @@ variable "proxy_https_password" {
   type        = string
   default     = ""
   description = "The password for the HTTPS Proxy."
+  nullable    = false
 }
 variable "proxy_https_username" {
   type        = string
   default     = ""
   description = "The username for the HTTPS Proxy."
+  nullable    = false
 }
 variable "proxy_https_port" {
   type        = number
   default     = 8443
   description = "The HTTPS Proxy port number.The port number of the HTTPS proxy must be between 1 and 65535, inclusive."
+  nullable    = false
 }
 variable "proxy_https_protocol" {
   type        = string
   default     = "https"
   description = " Protocol to use for the HTTPS Proxy."
+  nullable    = false
 }
 variable "docker_no_proxy" {
   type        = list(string)
   default     = []
   description = "Networks excluded from the proxy."
+  nullable    = false
 }
 variable "tags" {
   type        = list(map(string))

modules/trusted_registry/variables.tf

@@ -6,6 +6,7 @@ variable "description" {
   type        = string
   default     = ""
   description = "Description to be used to describe the trusted registry profile."
+  nullable    = false
 }
 
 variable "policy_name" {
@@ -17,11 +18,13 @@ variable "root_ca_registries" {
   type        = list(string)
   description = "List of root CA certificates."
   default     = []
+  nullable    = false
 }
 variable "unsigned_registries" {
   type        = list(string)
   description = "List of unsigned registries to be supported."
   default     = []
+  nullable    = false
 }
 variable "tags" {
   type        = list(map(string))

modules/version/variables.tf

@@ -14,6 +14,7 @@ variable "description" {
   type        = string
   default     = ""
   description = "Description to be used to describe the k8s version profile."
+  nullable    = false
 }
 variable "tags" {
   type        = list(map(string))