Skip to content

Commit 04a8fc1

Browse files
committed
Fix code review comments:
Changed the directory name Simplified the region tag Removed unnecessary comments.
1 parent 1440dcd commit 04a8fc1

File tree

4 files changed

+9
-15
lines changed
  • network_management/vpcflowlogs

4 files changed

+9
-15
lines changed

network_management/vpc_flow_logs_config/interconnect_attachment_basic/main.tf renamed to network_management/vpcflowlogs/interconnect_attachment_basic/main.tf

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,12 @@
1414
* limitations under the License.
1515
*/
1616

17-
# [START vpcflowlogs_create_basic_vpc_flow_logs_config_over_interconnect_attachment]
18-
# google_network_management_vpc_flow_logs_config.vpc_fl_config will be created
17+
# [START vpcflowlogs_interconnect_attachment_basic]
1918
resource "google_network_management_vpc_flow_logs_config" "vpc_fl_config" {
19+
provider = google-beta
2020
interconnect_attachment = "projects/example_project/regions/us-central1/interconnectAttachments/example_interconnect"
2121
location = "global"
2222
project = "example_project"
23-
provider = google-beta
2423
vpc_flow_logs_config_id = "example-config-id"
2524
}
26-
# [END vpcflowlogs_create_basic_vpc_flow_logs_config_over_interconnect_attachment]
25+
# [END vpcflowlogs_interconnect_attachment_basic]

network_management/vpc_flow_logs_config/interconnect_attachment_full/main.tf renamed to network_management/vpcflowlogs/interconnect_attachment_full/main.tf

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
# [START vpcflowlogs_create_vpc_flow_logs_config_over_interconnect_attachment_with_parameters]
18-
# google_network_management_vpc_flow_logs_config.vpc_fl_config will be created
17+
# [START vpcflowlogs_interconnect_attachment_full]
1918
resource "google_network_management_vpc_flow_logs_config" "vpc_fl_config" {
2019
aggregation_interval = "INTERVAL_10_MIN"
2120
description = "VPC Flow Logs over an Interconnect Attachment."
@@ -28,4 +27,4 @@ resource "google_network_management_vpc_flow_logs_config" "vpc_fl_config" {
2827
state = "ENABLED"
2928
vpc_flow_logs_config_id = "example-config-id"
3029
}
31-
# [END vpcflowlogs_create_vpc_flow_logs_config_over_interconnect_attachment_with_parameters]
30+
# [END vpcflowlogs_interconnect_attachment_full]

network_management/vpc_flow_logs_config/vpn_tunnel_basic/main.tf renamed to network_management/vpcflowlogs/vpn_tunnel_basic/main.tf

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,12 @@
1414
* limitations under the License.
1515
*/
1616

17-
# [START vpcflowlogs_create_basic_vpc_flow_logs_config_over_vpn_tunnel]
18-
19-
# google_network_management_vpc_flow_logs_config.vpc_fl_config will be created
17+
# [START vpcflowlogs_vpn_tunnel_basic]
2018
resource "google_network_management_vpc_flow_logs_config" "vpc_fl_config" {
2119
location = "global"
2220
project = "example_project"
2321
provider = google-beta
2422
vpc_flow_logs_config_id = "example-config-id"
2523
vpn_tunnel = "projects/example_project/regions/us-central1/vpnTunnels/example_vpn_tunnel"
2624
}
27-
# [END vpcflowlogs_create_basic_vpc_flow_logs_config_over_vpn_tunnel]
25+
# [END vpcflowlogs_vpn_tunnel_basic]

network_management/vpc_flow_logs_config/vpn_tunnel_full/main.tf renamed to network_management/vpcflowlogs/vpn_tunnel_full/main.tf

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
# [START vpcflowlogs_create_vpc_flow_logs_config_over_vpn_tunnel_with_parameters]
18-
19-
# google_network_management_vpc_flow_logs_config.vpc_fl_config will be created
17+
# [START vpcflowlogs_vpn_tunnel_full]
2018
resource "google_network_management_vpc_flow_logs_config" "vpc_fl_config" {
2119
aggregation_interval = "INTERVAL_10_MIN"
2220
description = "VPC Flow Logs over a VPN Gateway."
@@ -29,4 +27,4 @@ resource "google_network_management_vpc_flow_logs_config" "vpc_fl_config" {
2927
vpc_flow_logs_config_id = "example-config-id"
3028
vpn_tunnel = "projects/example_project/regions/us-central1/vpnTunnels/example_vpn_tunnel"
3129
}
32-
# [END vpcflowlogs_create_vpc_flow_logs_config_over_vpn_tunnel_with_parameters]
30+
# [END vpcflowlogs_vpn_tunnel_full]

0 commit comments

Comments
 (0)