Allow destruction of google_service_networking_connection when residual resources still exist

ericgribkoff · ericgribkoff · commit 0cb9e9eaa298 · 2024-11-06T18:11:25.000-08:00
See hashicorp/terraform-provider-google#18729 and b/308248337#comment7 for more context
diff --git a/vertex_ai/index_endpoint_deploy_vpc/main.tf b/vertex_ai/index_endpoint_deploy_vpc/main.tf
@@ -41,6 +41,8 @@ resource "google_service_networking_connection" "default" {
   network                 = google_compute_network.default.id
   service                 = "servicenetworking.googleapis.com"
   reserved_peering_ranges = [google_compute_global_address.default.name]
+  # Workaround to allow `terraform destroy`, see https://github.com/hashicorp/terraform-provider-google/issues/18729
+  deletion_policy = "ABANDON"
 }
 
 resource "google_compute_global_address" "default" {
diff --git a/vertex_ai/index_endpoint_mutate_vpc/main.tf b/vertex_ai/index_endpoint_mutate_vpc/main.tf
@@ -48,6 +48,8 @@ resource "google_service_networking_connection" "default" {
   network                 = google_compute_network.default.id
   service                 = "servicenetworking.googleapis.com"
   reserved_peering_ranges = [google_compute_global_address.default.name]
+  # Workaround to allow `terraform destroy`, see https://github.com/hashicorp/terraform-provider-google/issues/18729
+  deletion_policy = "ABANDON"
 }
 
 resource "google_compute_global_address" "default" {
diff --git a/vertex_ai/index_endpoint_vpc/main.tf b/vertex_ai/index_endpoint_vpc/main.tf
@@ -30,6 +30,8 @@ resource "google_service_networking_connection" "default" {
   network                 = google_compute_network.default.id
   service                 = "servicenetworking.googleapis.com"
   reserved_peering_ranges = [google_compute_global_address.default.name]
+  # Workaround to allow `terraform destroy`, see https://github.com/hashicorp/terraform-provider-google/issues/18729
+  deletion_policy = "ABANDON"
 }
 
 resource "google_compute_global_address" "default" {

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,8 @@ resource "google_service_networking_connection" "default" {`
`41`	`41`	`network = google_compute_network.default.id`
`42`	`42`	`service = "servicenetworking.googleapis.com"`
`43`	`43`	`reserved_peering_ranges = [google_compute_global_address.default.name]`
	`44`	+ # Workaround to allow `terraform destroy`, see https://github.com/hashicorp/terraform-provider-google/issues/18729
	`45`	`+ deletion_policy = "ABANDON"`
`44`	`46`	`}`
`45`	`47`
`46`	`48`	`resource "google_compute_global_address" "default" {`
Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,8 @@ resource "google_service_networking_connection" "default" {`
`48`	`48`	`network = google_compute_network.default.id`
`49`	`49`	`service = "servicenetworking.googleapis.com"`
`50`	`50`	`reserved_peering_ranges = [google_compute_global_address.default.name]`
	`51`	+ # Workaround to allow `terraform destroy`, see https://github.com/hashicorp/terraform-provider-google/issues/18729
	`52`	`+ deletion_policy = "ABANDON"`
`51`	`53`	`}`
`52`	`54`
`53`	`55`	`resource "google_compute_global_address" "default" {`
Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,8 @@ resource "google_service_networking_connection" "default" {`
`30`	`30`	`network = google_compute_network.default.id`
`31`	`31`	`service = "servicenetworking.googleapis.com"`
`32`	`32`	`reserved_peering_ranges = [google_compute_global_address.default.name]`
	`33`	+ # Workaround to allow `terraform destroy`, see https://github.com/hashicorp/terraform-provider-google/issues/18729
	`34`	`+ deletion_policy = "ABANDON"`
`33`	`35`	`}`
`34`	`36`
`35`	`37`	`resource "google_compute_global_address" "default" {`