reviewer updates

ronnieplooker · ronnieplooker · commit 2eff45ee0d38 · 2025-07-15T02:49:15.000-07:00
diff --git a/looker/looker-core-psc/main.tf b/looker/looker-core-psc/main.tf
@@ -1,4 +1,4 @@
-/**
+ /**
  * Copyright 2025 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ -28,8 +28,9 @@ resource "google_looker_instance" "default" {
   }
   psc_config {
     allowed_vpcs = ["projects/test-project/global/networks/test"]
-    # update only
-    # service_attachments = [{local_fqdn: "www.local-fqdn.com" target_service_attachment_uri: "projects/my-project/regions/us-east1/serviceAttachments/sa"}]
-  }
+    # (Optional) List of VPCs that are allowed ingress into the Looker instance.
+    service_attachments = [{local_fqdn: "www.local-fqdn.com" target_service_attachment_uri: "projects/my-project/regions/us-east1/serviceAttachments/sa"}]
+    # (Optional) List of egress service attachment configurations. local_fqdn is a fully qualified domain name that will be used in the private DNS record created for the service attachment. target_service_attachment_uri is the URI of the service attachment to connect to.
+   }
 }
 # [END looker_google_looker_instance_psc]

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-/**`
	`1`	`+ /**`
`2`	`2`	`* Copyright 2025 Google LLC`
`3`	`3`	`*`
`4`	`4`	`* Licensed under the Apache License, Version 2.0 (the "License");`
`@@ -28,8 +28,9 @@ resource "google_looker_instance" "default" {`
`28`	`28`	`}`
`29`	`29`	`psc_config {`
`30`	`30`	`allowed_vpcs = ["projects/test-project/global/networks/test"]`
`31`		`- # update only`
`32`		`- # service_attachments = [{local_fqdn: "www.local-fqdn.com" target_service_attachment_uri: "projects/my-project/regions/us-east1/serviceAttachments/sa"}]`
`33`		`- }`
	`31`	`+ # (Optional) List of VPCs that are allowed ingress into the Looker instance.`
	`32`	`+ service_attachments = [{local_fqdn: "www.local-fqdn.com" target_service_attachment_uri: "projects/my-project/regions/us-east1/serviceAttachments/sa"}]`
	`33`	`+ # (Optional) List of egress service attachment configurations. local_fqdn is a fully qualified domain name that will be used in the private DNS record created for the service attachment. target_service_attachment_uri is the URI of the service attachment to connect to.`
	`34`	`+ }`
`34`	`35`	`}`
`35`	`36`	`# [END looker_google_looker_instance_psc]`