Skip to content

feat(networksecurity): Remove google-beta provider from mirroring samples #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2025
Merged

feat(networksecurity): Remove google-beta provider from mirroring samples #834

merged 1 commit into from
Apr 6, 2025

Conversation

@duvni
Copy link
Contributor

@duvni duvni commented Apr 6, 2025

Description

Use the google provider (implicitly the default) instead of the google-beta provider for mirroring samples.
This will fix our docs that currently show the google-beta provider in their terraform samples.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

  • Yes, this sample will be (or already is) included on cloud.google.com
    Location(s):

  • No, this sample won't be included on cloud.google.com
    Reason:

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@duvni duvni requested review from a team as code owners April 6, 2025 08:00
@snippet-bot
Copy link

snippet-bot bot commented Apr 6, 2025 •
edited
Loading

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@duvni duvni requested a review from lisardggY April 6, 2025 08:55
lisardggY
lisardggY approved these changes Apr 6, 2025
View reviewed changes
Copy link

@lisardggY lisardggY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Very good! Fantastic!

@duvni duvni merged commit 9ff497b into terraform-google-modules:main Apr 6, 2025
5 checks passed
@duvni duvni deleted the pm2-docs branch April 6, 2025 08:58
niharika-98 pushed a commit to niharika-98/terraform-docs-samples that referenced this pull request Sep 7, 2025
@duvni @niharika-98
feat(networksecurity): Remove google-beta provider from mirroring sam…
ae2a58b 
…ples (terraform-google-modules#834)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lisardggY lisardggY lisardggY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@duvni @lisardggY