Skip to content

Commit a7ef590

Browse files
committed
fix integration tests
1 parent 9678337 commit a7ef590

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

test/integration/org/org_test.go

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -259,10 +259,9 @@ func TestOrg(t *testing.T) {
259259
// check tags applied to common and bootstrap folder
260260
commonConfig := terraform.OutputMap(t, bootstrap.GetTFOptions(), "common_config")
261261
bootstrapFolder := testutils.GetLastSplitElement(commonConfig["bootstrap_folder_name"], "/")
262-
263262
servicePerimeterLink := fmt.Sprintf("accessPolicies/%s/servicePerimeters/%s", policyID, org.GetStringOutput("service_perimeter_name"))
264263
accessLevel := fmt.Sprintf("accessPolicies/%s/accessLevels/%s", policyID, org.GetStringOutput("access_level_name_dry_run"))
265-
servicePerimeter, err := gcloud.RunCmdE(t, fmt.Sprintf("access-context-manager perimeters dry-run describe %s --policy %s --format=json", servicePerimeterLink, policyID))
264+
servicePerimeter, err := gcloud.RunCmdE(t, fmt.Sprintf("access-context-manager perimeters describe %s --policy %s", servicePerimeterLink, policyID))
266265
assert.NoError(err)
267266
perimeterName := org.GetStringOutput("service_perimeter_name")
268267
assert.True(strings.Contains(servicePerimeter, perimeterName), fmt.Sprintf("service perimeter %s should exist", perimeterName))
@@ -526,7 +525,7 @@ func TestOrg(t *testing.T) {
526525

527526
// verify seed project in perimeter
528527
sharedProjectNumber := bootstrap.GetStringOutput("seed_project_number")
529-
perimeter := gcloud.Runf(t, "access-context-manager perimeters dry-run describe %s --policy %s --format=json", servicePerimeterLink, policyID)
528+
perimeter := gcloud.Runf(t, "access-context-manager perimeters describe %s --policy %s", servicePerimeterLink, policyID)
530529
projectFormat := fmt.Sprintf("projects/%s", sharedProjectNumber)
531530
perimeterResources := utils.GetResultStrSlice(perimeter.Get("spec.resources").Array())
532531
assert.Contains(perimeterResources, projectFormat, fmt.Sprintf("dry-run service perimeter %s should contain %s", perimeterName, projectFormat))
@@ -545,7 +544,7 @@ func TestOrg(t *testing.T) {
545544
assert.Equal("ACTIVE", projects[0].Get("lifecycleState").String(), fmt.Sprintf("project %s should be ACTIVE", projectID))
546545
numberOutput := strings.ReplaceAll(hubAndSpokeProjectOutput, "_id", "_number") // "net_hub_project_number"
547546
projectNumber := org.GetStringOutput(numberOutput)
548-
perimeter := gcloud.Runf(t, "access-context-manager perimeters dry-run describe %s --policy %s --format=json", servicePerimeterLink, policyID)
547+
perimeter := gcloud.Runf(t, "access-context-manager perimeters describe %s --policy %s", servicePerimeterLink, policyID)
549548
projectFormat := fmt.Sprintf("projects/%s", projectNumber)
550549
perimeterResources := utils.GetResultStrSlice(perimeter.Get("spec.resources").Array())
551550
assert.Contains(perimeterResources, projectFormat, fmt.Sprintf("dry-run service perimeter %s should contain %s", perimeterName, projectFormat))
@@ -606,7 +605,7 @@ func TestOrg(t *testing.T) {
606605
prj := gcloud.Runf(t, "projects describe %s", projectID)
607606
assert.Equal("ACTIVE", prj.Get("lifecycleState").String(), fmt.Sprintf("project %s should be ACTIVE", projectID))
608607
projectNumber := prj.Get("projectNumber").String()
609-
perimeter, err := gcloud.RunCmdE(t, fmt.Sprintf("access-context-manager perimeters dry-run describe %s --policy %s", servicePerimeterLink, policyID))
608+
perimeter, err := gcloud.RunCmdE(t, fmt.Sprintf("access-context-manager perimeters describe %s --policy %s", servicePerimeterLink, policyID))
610609
assert.NoError(err)
611610
assert.True(strings.Contains(perimeter, projectNumber), fmt.Sprintf("dry-run service perimeter %s should contain project %s (number: %s)", perimeterName, projectID, projectNumber))
612611
enabledAPIS := gcloud.Runf(t, "services list --project %s", projectID).Array()
@@ -643,7 +642,7 @@ func TestOrg(t *testing.T) {
643642
prj := gcloud.Runf(t, "projects describe %s", projectID)
644643
assert.Equal(projectID, prj.Get("projectId").String(), fmt.Sprintf("project %s should exist", projectID))
645644
assert.Equal("ACTIVE", prj.Get("lifecycleState").String(), fmt.Sprintf("project %s should be ACTIVE", projectID))
646-
perimeter := gcloud.Runf(t, "access-context-manager perimeters dry-run describe %s --policy %s --format=json", servicePerimeterLink, policyID)
645+
perimeter := gcloud.Runf(t, "access-context-manager perimeters describe %s --policy %s", servicePerimeterLink, policyID)
647646
projectFormat := fmt.Sprintf("projects/%s", projectNumber)
648647
perimeterResources := utils.GetResultStrSlice(perimeter.Get("spec.resources").Array())
649648
assert.Contains(perimeterResources, projectFormat, fmt.Sprintf("dry-run service perimeter %s should contain %s", perimeterName, projectFormat))

0 commit comments

Comments
 (0)