Skip to content

Commit c386a98

Browse files
fix integration tests
1 parent 7eb6554 commit c386a98

File tree

1 file changed

+16
-5
lines changed

1 file changed

+16
-5
lines changed

test/integration/networks/networks_test.go

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -371,12 +371,12 @@ func TestNetworks(t *testing.T) {
371371
} {
372372
projectID := networks.GetStringOutput(fmt.Sprintf("%s_host_project_id", networkType))
373373

374-
if networkMode == "-spoke" {
374+
if strings.Contains(projectID, "prj-p") && networkMode != "-spoke" {
375375
for _, dnsType := range []string{
376376
"dns_zone_googleapis",
377377
"dns_zone_gcr",
378378
"dns_zone_pkg_dev",
379-
"dns_zone_peering_zone",
379+
"dns_zone_forward",
380380
} {
381381
dnsName := networkNames[networkType][dnsType]
382382
dnsZone := gcloud.Runf(t, "dns managed-zones describe %s --project %s --impersonate-service-account %s", dnsName, projectID, terraformSA)
@@ -387,7 +387,7 @@ func TestNetworks(t *testing.T) {
387387
"dns_zone_googleapis",
388388
"dns_zone_gcr",
389389
"dns_zone_pkg_dev",
390-
"dns_zone_forward",
390+
"dns_zone_peering_zone",
391391
} {
392392
dnsName := networkNames[networkType][dnsType]
393393
dnsZone := gcloud.Runf(t, "dns managed-zones describe %s --project %s --impersonate-service-account %s", dnsName, projectID, terraformSA)
@@ -469,10 +469,21 @@ func TestNetworks(t *testing.T) {
469469
assert.Equal(routerName, computeRouter.Get("name").String(), fmt.Sprintf("router %s should exist", routerName))
470470
assert.Equal("64514", computeRouter.Get("bgp.asn").String(), fmt.Sprintf("router %s should have bgp asm 64514", routerName))
471471
assert.Equal(networkSelfLink, computeRouter.Get("network").String(), fmt.Sprintf("router %s should be on network %s", routerName, networkNames[networkType]["network_name"]))
472+
assert.Contains(googleapisCIDR[envName][networkType], computeRouter.Get("bgp.advertisedIpRanges.1.range").String(), fmt.Sprintf("router %s should have range %s", routerName, googleapisCIDR[envName][networkType]))
473+
472474
if strings.Contains(projectID, "prj-p") && networkMode != "-spoke" {
473-
assert.Equal(bgpAdvertisedIpRange, computeRouter.Get("bgp.advertisedIpRanges.0.range").String(), fmt.Sprintf("router %s should have range %s", routerName, bgpAdvertisedIpRange))
474-
assert.Equal(googleapisCIDR[envName][networkType], computeRouter.Get("bgp.advertisedIpRanges.0.range").String(), fmt.Sprintf("router %s should have only range %s", routerName, googleapisCIDR[envName][networkType]))
475+
advertisedIpRanges := computeRouter.Get("bgp.advertisedIpRanges").Array()
476+
found := false
477+
for _, ipRange := range advertisedIpRanges {
478+
if ipRange.Get("range").String() == bgpAdvertisedIpRange {
479+
found = true
480+
break
481+
}
482+
}
483+
assert.True(found, fmt.Sprintf("router %s should have range %s", routerName, bgpAdvertisedIpRange))
484+
assert.True(found, fmt.Sprintf("router %s should have range %s", routerName, googleapisCIDR[envName][networkType]))
475485
}
486+
476487
}
477488
}
478489
}

0 commit comments

Comments
 (0)