Skip to content

Commit b8934d1

Browse files
Android Build Filesystem (ABFS) Teamsce-taid
authored andcommitted
feat: adopt the new google_secure_source_manager_hook resource.
PiperOrigin-RevId: 814269077
1 parent 8201fab commit b8934d1

File tree

7 files changed

+26
-62
lines changed

7 files changed

+26
-62
lines changed

examples/simple/compute.tf

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -64,29 +64,3 @@ resource "google_compute_instance" "abfs_client" {
6464
enable_vtpm = var.abfs_client_config.shielded_instance_config.enable_vtpm
6565
}
6666
}
67-
68-
module "ops_agent_policy" {
69-
count = var.create_client_instance_resource ? 1 : 0
70-
71-
source = "github.com/terraform-google-modules/terraform-google-cloud-operations/modules/ops-agent-policy?ref=v0.6.0"
72-
73-
project = google_compute_instance.abfs_client[0].project
74-
zone = google_compute_instance.abfs_client[0].zone
75-
assignment_id = format(
76-
"goog-ops-agent-%s-%s",
77-
var.abfs_client_config.goog_ops_agent_policy,
78-
google_compute_instance.abfs_client[0].zone
79-
)
80-
agents_rule = {
81-
package_state = "installed"
82-
version = "latest"
83-
}
84-
instance_filter = {
85-
all = false
86-
inclusion_labels = [{
87-
labels = {
88-
goog-ops-agent-policy = var.abfs_client_config.goog_ops_agent_policy
89-
}
90-
}]
91-
}
92-
}

examples/simple/dns.tf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ locals {
3737
module "cloud-dns-private-google-apis" {
3838
count = var.create_dns_zones ? 1 : 0
3939
source = "terraform-google-modules/cloud-dns/google"
40-
version = "5.3.0"
40+
version = "~>6.1.0"
4141

4242
description = "Private DNS zone for Google APIs"
4343
domain = "googleapis.com."
@@ -70,7 +70,7 @@ module "cloud-dns-private-google-apis" {
7070
module "cloud-dns-private-artifact-registry" {
7171
count = var.create_dns_zones ? 1 : 0
7272
source = "terraform-google-modules/cloud-dns/google"
73-
version = "5.3.0"
73+
version = "~>6.1.0"
7474

7575
description = "Private DNS zone for Artifact Registry"
7676
domain = "pkg.dev."
@@ -103,7 +103,7 @@ module "cloud-dns-private-artifact-registry" {
103103
module "source-repositories-private-artifact-registry" {
104104
count = var.create_dns_zones ? 1 : 0
105105
source = "terraform-google-modules/cloud-dns/google"
106-
version = "5.3.0"
106+
version = "~>6.1.0"
107107

108108
description = "Private DNS zone for Cloud Source Repositories"
109109
domain = "source.developers.google.com."

examples/simple/iam.tf

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,20 @@
1313
# limitations under the License.
1414

1515
locals {
16-
create_service_account = var.abfs_service_account_id == ""
16+
# go/keep-sorted start
17+
abfs_iam_roles = [
18+
"roles/artifactregistry.reader",
19+
"roles/logging.logWriter",
20+
"roles/monitoring.metricWriter",
21+
"roles/monitoring.viewer",
22+
"roles/spanner.databaseUser",
23+
"roles/stackdriver.resourceMetadata.writer",
24+
"roles/storage.objectAdmin",
25+
]
1726
abfs_service_account_email = local.create_service_account ? google_service_account.abfs[0].email : data.google_service_account.abfs[0].email
1827
abfs_service_account_unique_id = local.create_service_account ? google_service_account.abfs[0].unique_id : data.google_service_account.abfs[0].unique_id
28+
create_service_account = var.abfs_service_account_id == ""
29+
# go/keep-sorted end
1930
}
2031

2132
data "google_service_account" "abfs" {
@@ -38,22 +49,12 @@ resource "google_service_account" "abfs" {
3849
}
3950
}
4051

41-
module "project-iam-bindings" {
42-
source = "terraform-google-modules/iam/google//modules/projects_iam"
43-
version = "8.1.0"
44-
45-
projects = [data.google_project.project.project_id]
46-
mode = "authoritative"
47-
48-
bindings = {
49-
"roles/artifactregistry.reader" = ["serviceAccount:${local.abfs_service_account_email}"],
50-
"roles/logging.logWriter" = ["serviceAccount:${local.abfs_service_account_email}"],
51-
"roles/monitoring.metricWriter" = ["serviceAccount:${local.abfs_service_account_email}"],
52-
"roles/monitoring.viewer" = ["serviceAccount:${local.abfs_service_account_email}"],
53-
"roles/spanner.databaseUser" = ["serviceAccount:${local.abfs_service_account_email}"],
54-
"roles/stackdriver.resourceMetadata.writer" = ["serviceAccount:${local.abfs_service_account_email}"],
55-
"roles/storage.objectAdmin" = ["serviceAccount:${local.abfs_service_account_email}"],
56-
}
52+
resource "google_project_iam_member" "abfs_iam" {
53+
for_each = toset(local.abfs_iam_roles)
54+
55+
project = data.google_project.project.project_id
56+
role = each.value
57+
member = "serviceAccount:${local.abfs_service_account_email}"
5758

5859
depends_on = [
5960
module.project-services,

examples/simple/network.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ moved {
1919

2020
module "abfs_vpc" {
2121
source = "terraform-google-modules/network/google"
22-
version = "9.2.0"
22+
version = "~>12.0.0"
2323

2424
project_id = data.google_project.project.project_id
2525
network_name = var.abfs_network_name
@@ -106,7 +106,7 @@ resource "google_compute_router" "nat_router" {
106106

107107
module "cloud-nat" {
108108
source = "terraform-google-modules/cloud-nat/google"
109-
version = "~> 5.3"
109+
version = "~> 5.4.0"
110110

111111
project_id = var.project_id
112112
region = var.region

examples/simple/outputs.tf

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,3 @@ output "spanner_database_schema_creation" {
3636
EOT
3737
)
3838
}
39-
40-
output "webhook_setup_instructions" {
41-
description = "Instructions to set up the webhook trigger."
42-
value = var.create_cloud_workstation_resources ? module.cicd_foundation[0].webhook_setup_instructions : null
43-
sensitive = true
44-
}
45-
46-
output "webhook_setup_instructions_display" {
47-
description = "Instructions to set up the webhook trigger."
48-
value = var.create_cloud_workstation_resources ? module.cicd_foundation[0].webhook_setup_instructions_display : null
49-
}

examples/simple/services.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
module "project-services-cloud-resource-manager" {
1616
source = "terraform-google-modules/project-factory/google//modules/project_services"
17-
version = "18.0.0"
17+
version = "18.1.0"
1818

1919
project_id = var.project_id
2020
enable_apis = var.enable_apis
@@ -26,7 +26,7 @@ module "project-services-cloud-resource-manager" {
2626

2727
module "project-services" {
2828
source = "terraform-google-modules/project-factory/google//modules/project_services"
29-
version = "18.0.0"
29+
version = "18.1.0"
3030

3131
project_id = var.project_id
3232
enable_apis = var.enable_apis

examples/simple/terraform.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ terraform {
1717
required_providers {
1818
google = {
1919
source = "hashicorp/google"
20-
version = ">= 6.11.0"
20+
version = ">= 7.5.0"
2121
}
2222
}
2323
# grant Storage Object Admin role to the Google Identity invoking Terraform

0 commit comments

Comments
 (0)