Skip to content

Commit 918d234

Browse files
author
Zheng Qin
committed
minimal the root module requirements config
1 parent c6e9c73 commit 918d234

File tree

8 files changed

+40
-77
lines changed

8 files changed

+40
-77
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
# Make will use bash instead of sh
1919
SHELL := /usr/bin/env bash
2020

21-
DOCKER_TAG_VERSION_DEVELOPER_TOOLS := 1.25.4
21+
DOCKER_TAG_VERSION_DEVELOPER_TOOLS := 1.25
2222
DOCKER_IMAGE_DEVELOPER_TOOLS := cft/developer-tools
2323
REGISTRY_URL := gcr.io/cloud-foundation-cicd
2424
ENABLE_BPMETADATA := 1

metadata.yaml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -386,28 +386,13 @@ spec:
386386
roles:
387387
- level: Project
388388
roles:
389-
- roles/serviceusage.serviceUsageAdmin
390-
- roles/storage.admin
391389
- roles/bigquery.admin
392-
- roles/aiplatform.admin
393-
- roles/dataform.admin
394390
- roles/iam.serviceAccountAdmin
395-
- roles/logging.configWriter
396391
- roles/resourcemanager.projectIamAdmin
397-
- roles/run.invoker
398-
- roles/workflows.admin
399-
- roles/cloudfunctions.admin
400-
- roles/datalineage.viewer
401-
- roles/iam.serviceAccountTokenCreator
402-
- roles/iam.serviceAccountUser
403392
services:
404393
- bigquery.googleapis.com
405-
- bigqueryconnection.googleapis.com
406-
- bigquerystorage.googleapis.com
407-
- cloudkms.googleapis.com
408394
- cloudresourcemanager.googleapis.com
409395
- iam.googleapis.com
410-
- serviceusage.googleapis.com
411396
providerVersions:
412397
- source: hashicorp/google
413398
version: ">= 5.39, < 7"

modules/authorization/metadata.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,20 +93,20 @@ spec:
9393
roles:
9494
- level: Project
9595
roles:
96-
- roles/aiplatform.admin
97-
- roles/cloudfunctions.admin
98-
- roles/iam.serviceAccountAdmin
99-
- roles/serviceusage.serviceUsageAdmin
100-
- roles/storage.admin
10196
- roles/workflows.admin
102-
- roles/bigquery.admin
97+
- roles/cloudfunctions.admin
10398
- roles/dataform.admin
10499
- roles/datalineage.viewer
100+
- roles/iam.serviceAccountAdmin
105101
- roles/iam.serviceAccountTokenCreator
106102
- roles/iam.serviceAccountUser
107103
- roles/logging.configWriter
108104
- roles/resourcemanager.projectIamAdmin
105+
- roles/bigquery.admin
106+
- roles/aiplatform.admin
109107
- roles/run.invoker
108+
- roles/serviceusage.serviceUsageAdmin
109+
- roles/storage.admin
110110
services:
111111
- bigquery.googleapis.com
112112
- bigqueryconnection.googleapis.com

modules/data_warehouse/metadata.yaml

Lines changed: 19 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -32,29 +32,22 @@ spec:
3232
description: {}
3333
icon: assets/data_warehouse_icon_v1.png
3434
deploymentDuration:
35-
configurationSecs: 120
36-
deploymentSecs: 420
35+
configurationSecs: "120"
36+
deploymentSecs: "420"
3737
costEstimate:
3838
description: cost of this solution is $0.65
3939
url: https://cloud.google.com/products/calculator/#id=857776c6-49e8-4c6a-adc5-42a15b8fb67d
4040
cloudProducts:
41-
- productId: search_BIGQUERY_SECTION
42-
pageUrl: ""
43-
- productId: WORKFLOWS_SECTION
44-
pageUrl: ""
45-
- productId: STORAGE_SECTION
46-
pageUrl: ""
47-
- productId: ai-platform
48-
pageUrl: ""
49-
- productId: LOOKER_STUDIO_SECTION
50-
pageUrl: lookerstudio.google.com
51-
isExternal: true
52-
- productId: CLOUD_DMS_SECTION
53-
pageUrl: ""
54-
- productId: FUNCTIONS_SECTION
55-
pageUrl: ""
56-
- productId: DATAFORM_SECTION
57-
pageUrl: ""
41+
- productId: search_BIGQUERY_SECTION
42+
- productId: WORKFLOWS_SECTION
43+
- productId: STORAGE_SECTION
44+
- productId: ai-platform
45+
- productId: LOOKER_STUDIO_SECTION
46+
pageUrl: lookerstudio.google.com
47+
isExternal: true
48+
- productId: CLOUD_DMS_SECTION
49+
- productId: FUNCTIONS_SECTION
50+
- productId: DATAFORM_SECTION
5851
content:
5952
architecture:
6053
diagramUrl: www.gstatic.com/pantheon/images/solutions/data-warehouse-architecture_v6.svg
@@ -135,20 +128,20 @@ spec:
135128
roles:
136129
- level: Project
137130
roles:
138-
- roles/resourcemanager.projectIamAdmin
139-
- roles/run.invoker
131+
- roles/dataform.admin
140132
- roles/datalineage.viewer
141133
- roles/iam.serviceAccountTokenCreator
142134
- roles/logging.configWriter
143-
- roles/serviceusage.serviceUsageAdmin
144-
- roles/storage.admin
135+
- roles/run.invoker
145136
- roles/workflows.admin
146-
- roles/bigquery.admin
147137
- roles/aiplatform.admin
148-
- roles/cloudfunctions.admin
149-
- roles/dataform.admin
150138
- roles/iam.serviceAccountAdmin
151139
- roles/iam.serviceAccountUser
140+
- roles/resourcemanager.projectIamAdmin
141+
- roles/serviceusage.serviceUsageAdmin
142+
- roles/storage.admin
143+
- roles/bigquery.admin
144+
- roles/cloudfunctions.admin
152145
services:
153146
- bigquery.googleapis.com
154147
- bigqueryconnection.googleapis.com

modules/scheduled_queries/metadata.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,20 +59,20 @@ spec:
5959
roles:
6060
- level: Project
6161
roles:
62+
- roles/cloudfunctions.admin
63+
- roles/iam.serviceAccountAdmin
64+
- roles/serviceusage.serviceUsageAdmin
6265
- roles/storage.admin
6366
- roles/workflows.admin
64-
- roles/bigquery.admin
6567
- roles/aiplatform.admin
66-
- roles/cloudfunctions.admin
68+
- roles/dataform.admin
6769
- roles/datalineage.viewer
68-
- roles/iam.serviceAccountAdmin
6970
- roles/iam.serviceAccountTokenCreator
7071
- roles/iam.serviceAccountUser
71-
- roles/run.invoker
72-
- roles/dataform.admin
7372
- roles/logging.configWriter
7473
- roles/resourcemanager.projectIamAdmin
75-
- roles/serviceusage.serviceUsageAdmin
74+
- roles/run.invoker
75+
- roles/bigquery.admin
7676
services:
7777
- bigquery.googleapis.com
7878
- bigqueryconnection.googleapis.com

modules/udf/metadata.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -63,20 +63,20 @@ spec:
6363
roles:
6464
- level: Project
6565
roles:
66-
- roles/workflows.admin
67-
- roles/aiplatform.admin
68-
- roles/cloudfunctions.admin
69-
- roles/datalineage.viewer
66+
- roles/dataform.admin
7067
- roles/iam.serviceAccountAdmin
71-
- roles/iam.serviceAccountTokenCreator
7268
- roles/iam.serviceAccountUser
69+
- roles/resourcemanager.projectIamAdmin
7370
- roles/run.invoker
74-
- roles/storage.admin
71+
- roles/workflows.admin
7572
- roles/bigquery.admin
76-
- roles/dataform.admin
73+
- roles/aiplatform.admin
74+
- roles/datalineage.viewer
75+
- roles/iam.serviceAccountTokenCreator
7776
- roles/logging.configWriter
78-
- roles/resourcemanager.projectIamAdmin
7977
- roles/serviceusage.serviceUsageAdmin
78+
- roles/storage.admin
79+
- roles/cloudfunctions.admin
8080
services:
8181
- bigquery.googleapis.com
8282
- bigqueryconnection.googleapis.com

test/setup/iam.tf

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,8 @@ locals {
1818
per_module_roles = {
1919
root = [
2020
"roles/bigquery.admin",
21-
"roles/aiplatform.admin",
22-
"roles/cloudfunctions.admin",
23-
"roles/dataform.admin",
24-
"roles/datalineage.viewer",
2521
"roles/iam.serviceAccountAdmin",
26-
"roles/iam.serviceAccountTokenCreator",
27-
"roles/iam.serviceAccountUser",
28-
"roles/logging.configWriter",
2922
"roles/resourcemanager.projectIamAdmin",
30-
"roles/run.invoker",
31-
"roles/serviceusage.serviceUsageAdmin",
32-
"roles/storage.admin",
33-
"roles/workflows.admin"
3423
]
3524
authorization = [
3625
"roles/bigquery.admin",

test/setup/main.tf

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,8 @@
1616
locals {
1717
per_module_services = {
1818
root = [
19-
"cloudkms.googleapis.com",
2019
"cloudresourcemanager.googleapis.com",
2120
"bigquery.googleapis.com",
22-
"bigquerystorage.googleapis.com",
23-
"bigqueryconnection.googleapis.com",
24-
"serviceusage.googleapis.com",
2521
"iam.googleapis.com",
2622
]
2723
authorization = [

0 commit comments

Comments
 (0)