Skip to content

fix: added missing validations #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

fix: added missing validations #425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions metadata.display.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,14 @@ spec:
title: Source Uris
regexValidation: ^gs://([a-z0-9]([a-z0-9-.]*[a-z0-9])?)/([^#?]+)?$
validation: Must be a valid Google Cloud Storage URI.
google_sheets_options:
name: google_sheets_options
title: Google Sheets Options
properties:
skip_leading_rows:
name: skip_leading_rows
title: Skip Leading Rows
min: 0
Copy link
Collaborator

@q2w q2w Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: No max here? 0 for min add any value?

Copy link
Contributor Author

@pawan1210 pawan1210 Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't find any reference for max value.

hive_partitioning_options:
name: hive_partitioning_options
title: Hive Partitioning Options
Expand All @@ -124,6 +132,10 @@ spec:
value: UTF-8
- label: ISO-8859-1
value: ISO-8859-1
skip_leading_rows:
name: skip_leading_rows
title: Skip Leading Rows
min: 0
location:
name: location
title: Location
Expand All @@ -150,6 +162,8 @@ spec:
max_time_travel_hours:
name: max_time_travel_hours
title: Max Time Travel Hours
min: 48
max: 168
project_id:
name: project_id
title: Project Id
Expand Down