feat!: rename project input variable to project_id for consistency #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the blueprint to be compliant with the Application Design Center. Key changes: - Updated metadata.yaml files to include output types. - Added connection metadata for network, router, and vpn_tunnel inputs. - Added titles to display metadata to pass linting checks. - Enabled blueprint metadata validation in the CI pipeline.
This change renames the 'project' input variable to 'project_id' across the root module, submodules, and all examples to align with ADC compliance standards. An upgrade guide has been added to docs/upgrading_to_v8.0.md. BREAKING CHANGE: The 'project' variable has been renamed to 'project_id'. Users of this module will need to update their module calls to use the new 'project_id' input when upgrading to version 8.0.0 or later.
Contributor
Author
|
@bharathkkb @ayushmjain @q2w @imrannayer @krprabhat-eng Requesting to review this PR. |
bharathkkb
changed the title
bharathkkb
approved these changes
Oct 29, 2025
Member
|
/gcbrun |
yuktatechgog
changed the title
yuktatechgog
force-pushed
the
adc-compliance
branch
from
f76d082 to
d98c82d
Compare
Member
|
/gcbrun |
ayushmjain
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-BREAKING CHANGE: Renamed the project input variable to project_id across root and interface modules and examples for ADC consistency. An upgrade guide has been added to docs/upgrading_to_v8.0.md.
ADC Metadata:
-Updated metadata.yaml files with corrected version constraints for connections.
-Removed an unsupported values() function from a connection in the interface submodule's metadata.