Skip to content

Commit 57365a8

Browse files
committed
Get rid of null defaults for examples
1 parent 3dd4e97 commit 57365a8

File tree

9 files changed

+11
-28
lines changed

9 files changed

+11
-28
lines changed

examples/automatic-labelling-from-localhost/README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,9 @@ this directory:
2222

2323
| Name | Description | Type | Default | Required |
2424
|------|-------------|:----:|:-----:|:-----:|
25-
| network | The name or self_link of the network to create compute instance in. Only one of network or subnetwork should be specified. | string | `""` | no |
2625
| project\_id | The ID of the project to which resources will be applied. | string | n/a | yes |
2726
| region | The region in which resources will be applied. | string | n/a | yes |
28-
| subnetwork | The name or self_link of the subnetwork to create compute instance in. Only one of network or subnetwork should be specified. | string | `""` | no |
27+
| subnetwork | The name or self_link of the subnetwork to create compute instance in. | string | `"default"` | no |
2928
| zone | The zone in which resources will be applied. | string | n/a | yes |
3029

3130
## Outputs

examples/automatic-labelling-from-localhost/main.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ resource "google_compute_instance" "main" {
9090
}
9191

9292
network_interface {
93-
network = var.network
9493
subnetwork = var.subnetwork
9594
}
9695

examples/automatic-labelling-from-localhost/variables.tf

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,8 @@ variable "zone" {
2929
description = "The zone in which resources will be applied."
3030
}
3131

32-
variable "network" {
33-
type = string
34-
description = "The name or self_link of the network to create compute instance in. Only one of network or subnetwork should be specified."
35-
default = ""
36-
}
37-
3832
variable "subnetwork" {
3933
type = string
40-
description = "The name or self_link of the subnetwork to create compute instance in. Only one of network or subnetwork should be specified."
41-
default = ""
34+
description = "The name or self_link of the subnetwork to create compute instance in."
35+
default = "default"
4236
}

examples/automatic-labelling-from-repository/README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,9 @@ this directory:
2222

2323
| Name | Description | Type | Default | Required |
2424
|------|-------------|:----:|:-----:|:-----:|
25-
| network | The name or self_link of the network to create compute instance in. Only one of network or subnetwork should be specified. | string | `""` | no |
2625
| project\_id | The ID of the project to which resources will be applied. | string | n/a | yes |
2726
| region | The region in which resources will be applied. | string | n/a | yes |
28-
| subnetwork | The name or self_link of the subnetwork to create compute instance in. Only one of network or subnetwork should be specified. | string | `""` | no |
27+
| subnetwork | The name or self_link of the subnetwork to create compute instance in. | string | `""` | no |
2928
| zone | The zone in which resources will be applied. | string | n/a | yes |
3029

3130
## Outputs

examples/automatic-labelling-from-repository/main.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ resource "google_compute_instance" "main" {
119119
}
120120

121121
network_interface {
122-
network = var.network
123122
subnetwork = var.subnetwork
124123
}
125124

examples/automatic-labelling-from-repository/variables.tf

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,8 @@ variable "zone" {
2929
description = "The zone in which resources will be applied."
3030
}
3131

32-
variable "network" {
33-
type = string
34-
description = "The name or self_link of the network to create compute instance in. Only one of network or subnetwork should be specified."
35-
default = ""
36-
}
37-
3832
variable "subnetwork" {
3933
type = string
40-
description = "The name or self_link of the subnetwork to create compute instance in. Only one of network or subnetwork should be specified."
34+
description = "The name or self_link of the subnetwork to create compute instance in."
4135
default = ""
4236
}

modules/event-folder-log-entry/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ The following software dependencies must be installed on the system
4646
from which this module will be invoked:
4747

4848
- [Terraform][terraform-site] v0.12
49-
- [Terraform Provider for Google Cloud Platform][terraformm-provider-gcp-site] v2.5
49+
- [Terraform Provider for Google Cloud Platform][terraform-provider-gcp-site] v2.5
5050

5151
### IAM Roles
5252

@@ -69,4 +69,4 @@ following APIs enabled:
6969
[repository-function]: ../repository-function
7070
[root-module]: ../..
7171
[terraform-site]: https://www.terraform.io/
72-
[terraformm-provider-gcp-site]: https://github.com/terraform-providers/terraform-provider-google
72+
[terraform-provider-gcp-site]: https://github.com/terraform-providers/terraform-provider-google

modules/event-project-log-entry/README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ The following software dependencies must be installed on the system
4646
from which this module will be invoked:
4747

4848
- [Terraform][terraform-site] v0.12
49-
- [Terraform Provider for Google Cloud Platform][terraformm-provider-gcp-site] v2.5
49+
- [Terraform Provider for Google Cloud Platform][terraform-provider-gcp-site] v2.5
5050

5151
### IAM Roles
5252

@@ -69,5 +69,4 @@ following APIs enabled:
6969
[repository-function]: ../repository-function
7070
[root-module]: ../..
7171
[terraform-site]: https://www.terraform.io/
72-
[terraformm-provider-gcp-site]: https://github.com/terraform-providers/terraform-provider-google
73-
72+
[terraform-provider-gcp-site]: https://github.com/terraform-providers/terraform-provider-google

modules/repository-function/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ The following software dependencies must be installed on the system
5050
from which this module will be invoked:
5151

5252
- [Terraform][terraform-site] v0.12
53-
- [Terraform Provider for Google Cloud Platform][terraformm-provider-gcp-site] v2.5
53+
- [Terraform Provider for Google Cloud Platform][terraform-provider-gcp-site] v2.5
5454

5555
### IAM Roles
5656

@@ -70,4 +70,4 @@ following APIs enabled:
7070
[automatic-labelling-from-repository-example]: ../../examples/automatic-labelling-from-repository
7171
[event-project-log-entry-submodule]: ../event-project-log-entry
7272
[terraform-site]: https://www.terraform.io/
73-
[terraformm-provider-gcp-site]: https://github.com/terraform-providers/terraform-provider-google
73+
[terraform-provider-gcp-site]: https://github.com/terraform-providers/terraform-provider-google

0 commit comments

Comments
 (0)