Use unique name for example compute instances

Author: aaron-lane

examples/automatic-labelling-from-localhost/main.tf

@@ -89,7 +89,7 @@ resource "google_compute_instance" "main" {
   }
 
   machine_type = "f1-micro"
-  name         = "unlabelled"
+  name         = "unlabelled-${random_pet.main.id}"
   zone         = "${var.zone}"
 
   network_interface = {

examples/automatic-labelling-from-localhost/outputs.tf

@@ -0,0 +1,20 @@
+/**
+ * Copyright 2019 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+output "compute_instance_name" {
+  value       = "${google_compute_instance.main.name}"
+  description = "The name of the unlabelled Compute instance."
+}

examples/automatic-labelling-from-repository/main.tf

@@ -118,7 +118,7 @@ resource "google_compute_instance" "main" {
   }
 
   machine_type = "f1-micro"
-  name         = "unlabelled"
+  name         = "unlabelled-${random_pet.main.id}"
   zone         = "${var.zone}"
 
   network_interface = {

examples/automatic-labelling-from-repository/outputs.tf

@@ -0,0 +1,20 @@
+/**
+ * Copyright 2019 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+output "compute_instance_name" {
+  value       = "${google_compute_instance.main.name}"
+  description = "The name of the unlabelled Compute instance."
+}

test/fixtures/automatic-labelling-from-localhost/outputs.tf

@@ -14,6 +14,11 @@
  * limitations under the License.
  */
 
+output "compute_instance_name" {
+  value       = "${module.automatic_labelling_from_localhost.compute_instance_name}"
+  description = "The name of the unlabelled Compute instance."
+}
+
 output "project_id" {
   value       = "${var.project_id}"
   description = "The ID of the project to which resources are applied."

test/fixtures/automatic-labelling-from-repository/outputs.tf

@@ -14,6 +14,11 @@
  * limitations under the License.
  */
 
+output "compute_instance_name" {
+  value       = "${module.automatic_labelling_from_repository.compute_instance_name}"
+  description = "The name of the unlabelled Compute instance."
+}
+
 output "project_id" {
   value       = "${var.project_id}"
   description = "The ID of the project to which resources are applied."

test/integration/automatic-labelling/controls/automatically_labelled.rb

@@ -20,7 +20,7 @@
   describe google_compute_instance(
     project: attribute("project_id"),
     zone: attribute("zone"),
-    name: "unlabelled",
+    name: attribute("compute_instance_name"),
   ) do
     let :principal_email do
       JSON.parse(File.read(ENV.fetch("GOOGLE_APPLICATION_CREDENTIALS"))).fetch("client_email").split("@").first

test/integration/automatic-labelling/inspec.yml

@@ -20,6 +20,10 @@ depends:
     git: https://github.com/inspec/inspec-gcp.git
     tag: v0.10.0
 attributes:
+  - name: compute_instance_name
+    type: string
+    required: true
+    description: "The name of the unlabelled Compute instance."
   - name: project_id
     type: string
     required: true