Skip to content

Commit b1b6c91

Browse files
committed
Fixes #20: Add support for Terraform 0.12
#20 Updated Makefile and helpers to fix tests before upgrade
1 parent d3c322d commit b1b6c91

File tree

10 files changed

+773
-89
lines changed

10 files changed

+773
-89
lines changed

Makefile

Lines changed: 23 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -76,48 +76,59 @@ version:
7676
.PHONY: docker_run
7777
docker_run:
7878
docker run --rm -it \
79-
-e CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE=${CREDENTIALS_PATH} \
79+
-e PROJECT_ID \
80+
-e SERVICE_ACCOUNT_JSON \
8081
-e GOOGLE_APPLICATION_CREDENTIALS=${CREDENTIALS_PATH} \
8182
-v $(CURDIR):/cft/workdir \
8283
${DOCKER_REPO_BASE_KITCHEN_TERRAFORM} \
83-
/bin/bash
84+
/bin/bash -c "source test/integration.sh && setup_environment && exec /bin/bash"
8485

8586
.PHONY: docker_create
8687
docker_create:
8788
docker run --rm -it \
88-
-e CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE=${CREDENTIALS_PATH} \
89+
-e PROJECT_ID \
90+
-e SERVICE_ACCOUNT_JSON \
8991
-e GOOGLE_APPLICATION_CREDENTIALS=${CREDENTIALS_PATH} \
9092
-v $(CURDIR):/cft/workdir \
9193
${DOCKER_REPO_BASE_KITCHEN_TERRAFORM} \
92-
/bin/bash -c "kitchen create"
94+
/bin/bash -c "source test/integration.sh && setup_environment && kitchen create"
9395

9496
.PHONY: docker_converge
9597
docker_converge:
9698
docker run --rm -it \
97-
-e CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE=${CREDENTIALS_PATH} \
99+
-e PROJECT_ID \
100+
-e SERVICE_ACCOUNT_JSON \
98101
-e GOOGLE_APPLICATION_CREDENTIALS=${CREDENTIALS_PATH} \
99102
-v $(CURDIR):/cft/workdir \
100103
${DOCKER_REPO_BASE_KITCHEN_TERRAFORM} \
101-
/bin/bash -c "kitchen converge && kitchen converge"
104+
/bin/bash -c "source test/integration.sh && setup_environment && kitchen converge"
102105

103106
.PHONY: docker_verify
104107
docker_verify:
105108
docker run --rm -it \
106-
-e CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE=${CREDENTIALS_PATH} \
109+
-e PROJECT_ID \
110+
-e SERVICE_ACCOUNT_JSON \
107111
-e GOOGLE_APPLICATION_CREDENTIALS=${CREDENTIALS_PATH} \
108112
-v $(CURDIR):/cft/workdir \
109113
${DOCKER_REPO_BASE_KITCHEN_TERRAFORM} \
110-
/bin/bash -c "kitchen verify"
114+
/bin/bash -c "source test/integration.sh && setup_environment && kitchen verify"
111115

112116
.PHONY: docker_destroy
113117
docker_destroy:
114118
docker run --rm -it \
115-
-e CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE=${CREDENTIALS_PATH} \
119+
-e PROJECT_ID \
120+
-e SERVICE_ACCOUNT_JSON \
116121
-e GOOGLE_APPLICATION_CREDENTIALS=${CREDENTIALS_PATH} \
117122
-v $(CURDIR):/cft/workdir \
118123
${DOCKER_REPO_BASE_KITCHEN_TERRAFORM} \
119-
/bin/bash -c "kitchen destroy"
124+
/bin/bash -c "source test/integration.sh && setup_environment && kitchen destroy"
120125

121126
.PHONY: test_integration_docker
122-
test_integration_docker: docker_create docker_converge docker_verify docker_destroy
123-
@echo "Running test-kitchen tests in docker"
127+
test_integration_docker:
128+
docker run --rm -it \
129+
-e PROJECT_ID \
130+
-e SERVICE_ACCOUNT_JSON \
131+
-e GOOGLE_APPLICATION_CREDENTIALS=${CREDENTIALS_PATH} \
132+
-v $(CURDIR):/cft/workdir \
133+
${DOCKER_REPO_BASE_KITCHEN_TERRAFORM} \
134+
make test_integration
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
/function_source_copy

examples/delete-vms-without-cmek/main.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ module "localhost_function" {
4747

4848
description = "Deletes VMs created with disks not encrypted with CMEK"
4949
entry_point = "ReceiveMessage"
50-
runtime = "go111"
51-
timeout_s = "240"
50+
runtime = "go111"
51+
timeout_s = "240"
5252

5353
event_trigger = "${module.event_project_log_entry.function_event_trigger}"
5454
name = "${random_pet.main.id}"

examples/delete-vms-without-cmek/variables.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,3 @@ variable "region" {
2323
type = "string"
2424
description = "The region in which resources will be applied."
2525
}
26-

helpers/combine_docfiles.py

Lines changed: 0 additions & 59 deletions
This file was deleted.

0 commit comments

Comments
 (0)