Change default value to null

Dev25 · Dev25 · commit 25aed4187743 · 2019-08-21T12:30:42.000+01:00
diff --git a/autogen/main.tf b/autogen/main.tf
@@ -71,7 +71,7 @@ locals {
     node_metadata = var.node_metadata
   }]
 
-  cluster_authenticator_security_group = var.authenticator_security_group == "" ? [] : [{
+  cluster_authenticator_security_group = var.authenticator_security_group == null ? [] : [{
     security_group = var.authenticator_security_group
   }]
 
diff --git a/autogen/variables.tf b/autogen/variables.tf
@@ -386,7 +386,7 @@ variable "identity_namespace" {
 variable "authenticator_security_group" {
   type        = string
   description = "The name of the RBAC security group for use with Google security groups in Kubernetes RBAC. Group name must be in format gke-security-groups@yourdomain.com"
-  default     = ""
+  default     = null
 }
 
 {% endif %}
diff --git a/modules/beta-private-cluster/README.md b/modules/beta-private-cluster/README.md
@@ -136,7 +136,7 @@ In either case, upgrading to module version `v1.0.0` will trigger a recreation o
 
 | Name | Description | Type | Default | Required |
 |------|-------------|:----:|:-----:|:-----:|
-| authenticator\_security\_group | The name of the RBAC security group for use with Google security groups in Kubernetes RBAC. Group name must be in format gke-security-groups@yourdomain.com | string | `""` | no |
+| authenticator\_security\_group | The name of the RBAC security group for use with Google security groups in Kubernetes RBAC. Group name must be in format gke-security-groups@yourdomain.com | string | `"null"` | no |
 | basic\_auth\_password | The password to be used with Basic Authentication. | string | `""` | no |
 | basic\_auth\_username | The username to be used with Basic Authentication. An empty value will disable Basic Authentication, which is the recommended configuration. | string | `""` | no |
 | cloudrun | (Beta) Enable CloudRun addon | string | `"false"` | no |
diff --git a/modules/beta-private-cluster/main.tf b/modules/beta-private-cluster/main.tf
@@ -66,7 +66,7 @@ locals {
     node_metadata = var.node_metadata
   }]
 
-  cluster_authenticator_security_group = var.authenticator_security_group == "" ? [] : [{
+  cluster_authenticator_security_group = var.authenticator_security_group == null ? [] : [{
     security_group = var.authenticator_security_group
   }]
 
diff --git a/modules/beta-private-cluster/variables.tf b/modules/beta-private-cluster/variables.tf
@@ -383,6 +383,6 @@ variable "identity_namespace" {
 variable "authenticator_security_group" {
   type        = string
   description = "The name of the RBAC security group for use with Google security groups in Kubernetes RBAC. Group name must be in format gke-security-groups@yourdomain.com"
-  default     = ""
+  default     = null
 }
 
diff --git a/modules/beta-public-cluster/README.md b/modules/beta-public-cluster/README.md
@@ -131,7 +131,7 @@ In either case, upgrading to module version `v1.0.0` will trigger a recreation o
 
 | Name | Description | Type | Default | Required |
 |------|-------------|:----:|:-----:|:-----:|
-| authenticator\_security\_group | The name of the RBAC security group for use with Google security groups in Kubernetes RBAC. Group name must be in format gke-security-groups@yourdomain.com | string | `""` | no |
+| authenticator\_security\_group | The name of the RBAC security group for use with Google security groups in Kubernetes RBAC. Group name must be in format gke-security-groups@yourdomain.com | string | `"null"` | no |
 | basic\_auth\_password | The password to be used with Basic Authentication. | string | `""` | no |
 | basic\_auth\_username | The username to be used with Basic Authentication. An empty value will disable Basic Authentication, which is the recommended configuration. | string | `""` | no |
 | cloudrun | (Beta) Enable CloudRun addon | string | `"false"` | no |
diff --git a/modules/beta-public-cluster/main.tf b/modules/beta-public-cluster/main.tf
@@ -66,7 +66,7 @@ locals {
     node_metadata = var.node_metadata
   }]
 
-  cluster_authenticator_security_group = var.authenticator_security_group == "" ? [] : [{
+  cluster_authenticator_security_group = var.authenticator_security_group == null ? [] : [{
     security_group = var.authenticator_security_group
   }]
 
diff --git a/modules/beta-public-cluster/variables.tf b/modules/beta-public-cluster/variables.tf
@@ -359,6 +359,6 @@ variable "identity_namespace" {
 variable "authenticator_security_group" {
   type        = string
   description = "The name of the RBAC security group for use with Google security groups in Kubernetes RBAC. Group name must be in format gke-security-groups@yourdomain.com"
-  default     = ""
+  default     = null
 }
 

Original file line number	Diff line number	Diff line change
`@@ -386,7 +386,7 @@ variable "identity_namespace" {`
`386`	`386`	`variable "authenticator_security_group" {`
`387`	`387`	`type = string`
`388`	`388`	`description = "The name of the RBAC security group for use with Google security groups in Kubernetes RBAC. Group name must be in format [email protected]"`
`389`		`- default = ""`
	`389`	`+ default = null`
`390`	`390`	`}`
`391`	`391`
`392`	`392`	`{% endif %}`
Original file line number	Diff line number	Diff line change
`@@ -383,6 +383,6 @@ variable "identity_namespace" {`
`383`	`383`	`variable "authenticator_security_group" {`
`384`	`384`	`type = string`
`385`	`385`	`description = "The name of the RBAC security group for use with Google security groups in Kubernetes RBAC. Group name must be in format [email protected]"`
`386`		`- default = ""`
	`386`	`+ default = null`
`387`	`387`	`}`
`388`	`388`
Original file line number	Diff line number	Diff line change
`@@ -359,6 +359,6 @@ variable "identity_namespace" {`
`359`	`359`	`variable "authenticator_security_group" {`
`360`	`360`	`type = string`
`361`	`361`	`description = "The name of the RBAC security group for use with Google security groups in Kubernetes RBAC. Group name must be in format [email protected]"`
`362`		`- default = ""`
	`362`	`+ default = null`
`363`	`363`	`}`
`364`	`364`