Synchronize zonal and regional node pool auto_upgrade default

adrienthebo · adrienthebo · commit 2db1bcde5f3f · 2019-03-11T18:03:45.000-07:00
The regional and zonal node pool configurations had different defaults
for `auto_upgrade`. We prefer auto-upgrading node pools in general, and
moreover having different defaults for regional and zonal node pools is
very surprising.

This commit reconciles the difference by changing the zonal node pool
auto_upgrade default to true.
diff --git a/cluster_zonal.tf b/cluster_zonal.tf
@@ -108,7 +108,7 @@ resource "google_container_node_pool" "zonal_pools" {
 
   management {
     auto_repair  = "${lookup(var.node_pools[count.index], "auto_repair", true)}"
-    auto_upgrade = "${lookup(var.node_pools[count.index], "auto_upgrade", false)}"
+    auto_upgrade = "${lookup(var.node_pools[count.index], "auto_upgrade", true)}"
   }
 
   node_config {

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@ resource "google_container_node_pool" "zonal_pools" {`
`108`	`108`
`109`	`109`	`management {`
`110`	`110`	`auto_repair = "${lookup(var.node_pools[count.index], "auto_repair", true)}"`
`111`		`- auto_upgrade = "${lookup(var.node_pools[count.index], "auto_upgrade", false)}"`
	`111`	`+ auto_upgrade = "${lookup(var.node_pools[count.index], "auto_upgrade", true)}"`
`112`	`112`	`}`
`113`	`113`
`114`	`114`	`node_config {`