Skip to content

Commit 2f14901

Browse files
authored
chore: document wait for cluster removal (#802)
* chore: document wait for cluster removal * add full plan * fmt
1 parent 356ed6d commit 2f14901

File tree

1 file changed

+38
-0
lines changed

1 file changed

+38
-0
lines changed

docs/upgrading_to_v13.0.md

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,3 +35,41 @@ module. This release adapts to this requirement.
3535
The yaml contents are rendered dynamically and passed via STDIN which fixes errors due to `operator_cr.yaml` file not being present between ephemeral pipeline runs.
3636

3737
This is destructive and will result in deletion and recreation of the ACM operator.
38+
39+
### Wait for cluster script removed
40+
41+
[wait-for-cluster.sh](https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/2c4a2b11b9be01c392c9d3a0c5c720973dbffebf/cluster.tf#L323) used to ensure that the cluster is in a ready state has been removed due to [improvements](https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/issues/800) in the provider. As part of the upgrade, Terraform might indicate that the `wait_for_cluster` null_resource must be destroyed. This is no-op and can be safely applied:
42+
43+
```
44+
# module.example.module.gke.module.gcloud_wait_for_cluster.null_resource.module_depends_on[0] will be destroyed
45+
- resource "null_resource" "module_depends_on" {
46+
- id = "8092231570921454387" -> null
47+
- triggers = {
48+
- "value" = "2"
49+
} -> null
50+
}
51+
52+
# module.example.module.gke.module.gcloud_wait_for_cluster.null_resource.run_command[0] will be destroyed
53+
- resource "null_resource" "run_command" {
54+
- id = "5198854261759708357" -> null
55+
- triggers = {
56+
- "arguments" = "de7f9e59f7436cdec4c8fc34fb8e9833"
57+
- "create_cmd_body" = "PROJECT_ID CLUSTER_NAME CLUSTER_LOCATION "
58+
- "create_cmd_entrypoint" = "../../../scripts/wait-for-cluster.sh"
59+
- "gcloud_bin_abs_path" = "/google-cloud-sdk/bin"
60+
- "md5" = "4149df8255e42ea6781ec241e82e9e69"
61+
} -> null
62+
}
63+
64+
# module.example.module.gke.module.gcloud_wait_for_cluster.null_resource.run_destroy_command[0] will be destroyed
65+
- resource "null_resource" "run_destroy_command" {
66+
- id = "6787683359757867074" -> null
67+
- triggers = {
68+
- "destroy_cmd_body" = "PROJECT_ID CLUSTER_NAME CLUSTER_LOCATION "
69+
- "destroy_cmd_entrypoint" = "../../../scripts/wait-for-cluster.sh"
70+
- "gcloud_bin_abs_path" = "/google-cloud-sdk/bin"
71+
} -> null
72+
}
73+
74+
Plan: 0 to add, 0 to change, 3 to destroy.
75+
```

0 commit comments

Comments
 (0)