Skip to content

Commit 7ee9c63

Browse files
committed
Only configure cloudrun_config if enabled
Explicitly configuring cloudrun_config as disabled is a breaking change which will recreate the cluster.
1 parent 01415bb commit 7ee9c63

File tree

3 files changed

+8
-11
lines changed

3 files changed

+8
-11
lines changed

autogen/cluster_regional.tf

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,7 @@ resource "google_container_cluster" "primary" {
7575
disabled = "${var.istio ? 0 : 1}"
7676
}
7777

78-
cloudrun_config {
79-
disabled = "${var.cloudrun ? 0 : 1}"
80-
}
78+
cloudrun_config = "${local.cluster_cloudrun_config["${var.cloudrun ? "enabled" : "disabled"}"]}"
8179
{% endif %}
8280
}
8381

autogen/cluster_zonal.tf

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,7 @@ resource "google_container_cluster" "zonal_primary" {
7676
disabled = "${var.istio ? 0 : 1}"
7777
}
7878

79-
cloudrun_config {
80-
disabled = "${var.cloudrun ? 0 : 1}"
81-
}
79+
cloudrun_config = "${local.cluster_cloudrun_config["${var.cloudrun ? "enabled" : "disabled"}"]}"
8280
{% endif %}
8381
}
8482

autogen/main.tf

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,11 @@ locals {
4848
disabled = [{enabled = "false"}]
4949
}
5050

51+
cluster_cloudrun_config = {
52+
enabled = [{disabled = "false"}]
53+
disabled = []
54+
}
55+
5156
cluster_type_output_name = {
5257
regional = "${element(concat(google_container_cluster.primary.*.name, list("")), 0)}"
5358
zonal = "${element(concat(google_container_cluster.zonal_primary.*.name, list("")), 0)}"
@@ -144,10 +149,6 @@ locals {
144149
zonal = "${element(concat(google_container_cluster.zonal_primary.*.addons_config.0.istio_config.0.disabled, list("")), 0)}"
145150
}
146151

147-
cluster_type_output_cloudrun_enabled = {
148-
regional = "${element(concat(google_container_cluster.primary.*.addons_config.0.cloudrun_config.0.disabled, list("")), 0)}"
149-
zonal = "${element(concat(google_container_cluster.zonal_primary.*.addons_config.0.cloudrun_config.0.disabled, list("")), 0)}"
150-
}
151152
cluster_type_output_pod_security_policy_enabled = {
152153
regional = "${element(concat(google_container_cluster.primary.*.pod_security_policy_config.0.enabled, list("")), 0)}"
153154
zonal = "${element(concat(google_container_cluster.zonal_primary.*.pod_security_policy_config.0.enabled, list("")), 0)}"
@@ -188,7 +189,7 @@ locals {
188189
{% if beta_cluster %}
189190
# BETA features
190191
cluster_istio_enabled = "${local.cluster_type_output_istio_enabled[local.cluster_type] ? false : true}"
191-
cluster_cloudrun_enabled = "${local.cluster_type_output_cloudrun_enabled[local.cluster_type] ? false : true}"
192+
cluster_cloudrun_enabled = "${var.cloudrun}"
192193

193194
cluster_pod_security_policy_enabled = "${local.cluster_type_output_pod_security_policy_enabled[local.cluster_type] ? true : false}"
194195
# /BETA features

0 commit comments

Comments
 (0)