chore(CI): remove assert so polling is honored (#2037)

apeabody · web-flow · commit b1fb1b39cea3 · 2024-08-16T00:36:50.000Z
diff --git a/test/integration/deploy_service/deploy_service_test.go b/test/integration/deploy_service/deploy_service_test.go
@@ -50,10 +50,11 @@ func TestDeployService(t *testing.T) {
 		pollHTTPEndPoint := func(cmd string) func() (bool, error) {
 			return func() (bool, error) {
 				_, err := http.Get(cmd)
-				if assert.NoError(err) {
-					return false, nil
+				if err != nil {
+					t.Logf("%s", err)
+					return true, err
 				}
-				return true, nil
+				return false, nil
 			}
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -50,10 +50,11 @@ func TestDeployService(t *testing.T) {`
`50`	`50`	`pollHTTPEndPoint := func(cmd string) func() (bool, error) {`
`51`	`51`	`return func() (bool, error) {`
`52`	`52`	`_, err := http.Get(cmd)`
`53`		`- if assert.NoError(err) {`
`54`		`- return false, nil`
	`53`	`+ if err != nil {`
	`54`	`+ t.Logf("%s", err)`
	`55`	`+ return true, err`
`55`	`56`	`}`
`56`		`- return true, nil`
	`57`	`+ return false, nil`
`57`	`58`	`}`
`58`	`59`	`}`
`59`	`60`