code review changes

Author: arthurlapertosa

README.md

@@ -347,6 +347,7 @@ The node_pools variable takes the following parameters:
 | image_maximum_gc_age | Defines the maximum age an image can be unused before it is garbage collected. | null | Optional |
 | allowed_unsafe_sysctls | Defines a comma-separated allowlist of unsafe sysctls or sysctl patterns which can be set on the Pods. This should be passed as comma separated string. | null | Optional |
 | enable_confidential_nodes | An optional flag to enable confidential node config. | false | Optional |
+| confidential_instance_type | Defines the type of technology used by the confidential node. | null | Optional |
 | disk_size_gb | Size of the disk attached to each node, specified in GB. The smallest allowed disk size is 10GB | 100 | Optional |
 | disk_type | Type of the disk attached to each node (e.g. 'pd-standard' or 'pd-ssd') | pd-standard | Optional |
 | effect | Effect for the taint | | Required |

autogen/main/README.md

@@ -214,6 +214,7 @@ The node_pools variable takes the following parameters:
 | image_maximum_gc_age | Defines the maximum age an image can be unused before it is garbage collected. | null | Optional |
 | allowed_unsafe_sysctls | Defines a comma-separated allowlist of unsafe sysctls or sysctl patterns which can be set on the Pods. This should be passed as comma separated string. | null | Optional |
 | enable_confidential_nodes | An optional flag to enable confidential node config. | false | Optional |
+| confidential_instance_type | Defines the type of technology used by the confidential node. | null | Optional |
 | disk_size_gb | Size of the disk attached to each node, specified in GB. The smallest allowed disk size is 10GB | 100 | Optional |
 | disk_type | Type of the disk attached to each node (e.g. 'pd-standard' or 'pd-ssd') | pd-standard | Optional |
 | effect | Effect for the taint | | Required |

examples/confidential_gpu_public/main.tf

@@ -98,13 +98,13 @@ module "gke" {
 
 module "kubectl" {
   source  = "terraform-google-modules/gcloud/google//modules/kubectl-wrapper"
-  version = "~> 3.0"
+  version = "~> 4.0"
 
   project_id              = var.project_id
   cluster_name            = module.gke.name
   cluster_location        = module.gke.location
   module_depends_on       = [module.gke.endpoint]
-  kubectl_create_command  = "kubectl apply -f https://raw.githubusercontent.com/GoogleCloudPlatform/container-engine-accelerators/refs/heads/master/nvidia-driver-installer/cos/daemonset-confidential.yaml"
-  kubectl_destroy_command = "kubectl delete -f https://raw.githubusercontent.com/GoogleCloudPlatform/container-engine-accelerators/refs/heads/master/nvidia-driver-installer/cos/daemonset-confidential.yaml"
+  kubectl_create_command  = "kubectl apply -f https://raw.githubusercontent.com/GoogleCloudPlatform/container-engine-accelerators/5619568e366f5ea5de4431bbe8e68934c5f582da/nvidia-driver-installer/cos/daemonset-confidential.yaml"
+  kubectl_destroy_command = "kubectl delete -f https://raw.githubusercontent.com/GoogleCloudPlatform/container-engine-accelerators/5619568e366f5ea5de4431bbe8e68934c5f582da/nvidia-driver-installer/cos/daemonset-confidential.yaml"
   skip_download           = true
 }

examples/confidential_gpu_public/network.tf

@@ -16,7 +16,7 @@
 
 module "gcp-network" {
   source  = "terraform-google-modules/network/google"
-  version = "~> 11.0"
+  version = "~> 12.0"
 
   project_id   = var.project_id
   network_name = local.network_name

modules/beta-private-cluster-update-variant/README.md

@@ -400,6 +400,7 @@ The node_pools variable takes the following parameters:
 | image_maximum_gc_age | Defines the maximum age an image can be unused before it is garbage collected. | null | Optional |
 | allowed_unsafe_sysctls | Defines a comma-separated allowlist of unsafe sysctls or sysctl patterns which can be set on the Pods. This should be passed as comma separated string. | null | Optional |
 | enable_confidential_nodes | An optional flag to enable confidential node config. | false | Optional |
+| confidential_instance_type | Defines the type of technology used by the confidential node. | null | Optional |
 | disk_size_gb | Size of the disk attached to each node, specified in GB. The smallest allowed disk size is 10GB | 100 | Optional |
 | disk_type | Type of the disk attached to each node (e.g. 'pd-standard' or 'pd-ssd') | pd-standard | Optional |
 | effect | Effect for the taint | | Required |

modules/beta-private-cluster/README.md

@@ -378,6 +378,7 @@ The node_pools variable takes the following parameters:
 | image_maximum_gc_age | Defines the maximum age an image can be unused before it is garbage collected. | null | Optional |
 | allowed_unsafe_sysctls | Defines a comma-separated allowlist of unsafe sysctls or sysctl patterns which can be set on the Pods. This should be passed as comma separated string. | null | Optional |
 | enable_confidential_nodes | An optional flag to enable confidential node config. | false | Optional |
+| confidential_instance_type | Defines the type of technology used by the confidential node. | null | Optional |
 | disk_size_gb | Size of the disk attached to each node, specified in GB. The smallest allowed disk size is 10GB | 100 | Optional |
 | disk_type | Type of the disk attached to each node (e.g. 'pd-standard' or 'pd-ssd') | pd-standard | Optional |
 | effect | Effect for the taint | | Required |

modules/beta-public-cluster-update-variant/README.md

@@ -386,6 +386,7 @@ The node_pools variable takes the following parameters:
 | image_maximum_gc_age | Defines the maximum age an image can be unused before it is garbage collected. | null | Optional |
 | allowed_unsafe_sysctls | Defines a comma-separated allowlist of unsafe sysctls or sysctl patterns which can be set on the Pods. This should be passed as comma separated string. | null | Optional |
 | enable_confidential_nodes | An optional flag to enable confidential node config. | false | Optional |
+| confidential_instance_type | Defines the type of technology used by the confidential node. | null | Optional |
 | disk_size_gb | Size of the disk attached to each node, specified in GB. The smallest allowed disk size is 10GB | 100 | Optional |
 | disk_type | Type of the disk attached to each node (e.g. 'pd-standard' or 'pd-ssd') | pd-standard | Optional |
 | effect | Effect for the taint | | Required |

modules/beta-public-cluster/README.md

@@ -364,6 +364,7 @@ The node_pools variable takes the following parameters:
 | image_maximum_gc_age | Defines the maximum age an image can be unused before it is garbage collected. | null | Optional |
 | allowed_unsafe_sysctls | Defines a comma-separated allowlist of unsafe sysctls or sysctl patterns which can be set on the Pods. This should be passed as comma separated string. | null | Optional |
 | enable_confidential_nodes | An optional flag to enable confidential node config. | false | Optional |
+| confidential_instance_type | Defines the type of technology used by the confidential node. | null | Optional |
 | disk_size_gb | Size of the disk attached to each node, specified in GB. The smallest allowed disk size is 10GB | 100 | Optional |
 | disk_type | Type of the disk attached to each node (e.g. 'pd-standard' or 'pd-ssd') | pd-standard | Optional |
 | effect | Effect for the taint | | Required |

modules/private-cluster-update-variant/README.md

@@ -383,6 +383,7 @@ The node_pools variable takes the following parameters:
 | image_maximum_gc_age | Defines the maximum age an image can be unused before it is garbage collected. | null | Optional |
 | allowed_unsafe_sysctls | Defines a comma-separated allowlist of unsafe sysctls or sysctl patterns which can be set on the Pods. This should be passed as comma separated string. | null | Optional |
 | enable_confidential_nodes | An optional flag to enable confidential node config. | false | Optional |
+| confidential_instance_type | Defines the type of technology used by the confidential node. | null | Optional |
 | disk_size_gb | Size of the disk attached to each node, specified in GB. The smallest allowed disk size is 10GB | 100 | Optional |
 | disk_type | Type of the disk attached to each node (e.g. 'pd-standard' or 'pd-ssd') | pd-standard | Optional |
 | effect | Effect for the taint | | Required |

modules/private-cluster/README.md

@@ -361,6 +361,7 @@ The node_pools variable takes the following parameters:
 | image_maximum_gc_age | Defines the maximum age an image can be unused before it is garbage collected. | null | Optional |
 | allowed_unsafe_sysctls | Defines a comma-separated allowlist of unsafe sysctls or sysctl patterns which can be set on the Pods. This should be passed as comma separated string. | null | Optional |
 | enable_confidential_nodes | An optional flag to enable confidential node config. | false | Optional |
+| confidential_instance_type | Defines the type of technology used by the confidential node. | null | Optional |
 | disk_size_gb | Size of the disk attached to each node, specified in GB. The smallest allowed disk size is 10GB | 100 | Optional |
 | disk_type | Type of the disk attached to each node (e.g. 'pd-standard' or 'pd-ssd') | pd-standard | Optional |
 | effect | Effect for the taint | | Required |