Skip to content

Commit f43ad46

Browse files
authored
fix: updated description in nodepool field (#2471)
1 parent 3164c2c commit f43ad46

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

modules/gke-node-pool/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
| Name | Description | Type | Default | Required |
88
|------|-------------|------|---------|:--------:|
99
| autoscaling | Configuration required by cluster autoscaler to adjust the size of the node pool to the current cluster usage. | <pre>object({<br> min_node_count = optional(number)<br> max_node_count = optional(number)<br> total_min_node_count = optional(number)<br> total_max_node_count = optional(number)<br> location_policy = optional(string)<br> })</pre> | <pre>{<br> "max_node_count": 100,<br> "min_node_count": 1<br>}</pre> | no |
10-
| cluster | The cluster to create the node pool for. Cluster must be present in location provided for clusters. May be specified in the format projects/{{project\_id}}/locations/{{location}}/clusters/{{cluster}} or as just the name of the cluster. | `string` | n/a | yes |
10+
| cluster | The cluster to create the node pool for. Cluster must be present in location provided for clusters. May be specified in the format projects/{project\_id}/locations/{location}/clusters/{cluster} or as just the name of the cluster. | `string` | n/a | yes |
1111
| initial\_node\_count | The initial number of nodes for the pool. In regional or multi-zonal clusters, this is the number of nodes per zone. | `number` | `null` | no |
1212
| kubernetes\_version | The Kubernetes version for the nodes in this pool. Note that if this field and auto\_upgrade are both specified, they will fight each other for what the node version should be, so setting both is highly discouraged. While a fuzzy version can be specified, it's recommended that you specify explicit versions as Terraform will see spurious diffs when fuzzy versions are used. See the google\_container\_engine\_versions data source's version\_prefix field to approximate fuzzy versions in a Terraform-compatible way. | `string` | `null` | no |
1313
| location | The location (region or zone) of the cluster. | `string` | `null` | no |

modules/gke-node-pool/metadata.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ spec:
127127
interfaces:
128128
variables:
129129
- name: cluster
130-
description: The cluster to create the node pool for. Cluster must be present in location provided for clusters. May be specified in the format projects/{{project_id}}/locations/{{location}}/clusters/{{cluster}} or as just the name of the cluster.
130+
description: The cluster to create the node pool for. Cluster must be present in location provided for clusters. May be specified in the format projects/{project_id}/locations/{location}/clusters/{cluster} or as just the name of the cluster.
131131
varType: string
132132
required: true
133133
connections:
@@ -409,9 +409,9 @@ spec:
409409
roles:
410410
- level: Project
411411
roles:
412+
- roles/compute.admin
412413
- roles/container.admin
413414
- roles/iam.serviceAccountUser
414-
- roles/compute.admin
415415
services:
416416
- compute.googleapis.com
417417
- container.googleapis.com

modules/gke-node-pool/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616

1717
variable "cluster" {
18-
description = "The cluster to create the node pool for. Cluster must be present in location provided for clusters. May be specified in the format projects/{{project_id}}/locations/{{location}}/clusters/{{cluster}} or as just the name of the cluster."
18+
description = "The cluster to create the node pool for. Cluster must be present in location provided for clusters. May be specified in the format projects/{project_id}/locations/{location}/clusters/{cluster} or as just the name of the cluster."
1919
type = string
2020
}
2121

0 commit comments

Comments
 (0)