Skip to content

Conversation

@DrFaust92
Copy link
Contributor

Fuse CSI Driver is not supported for autopilot

@DrFaust92 DrFaust92 requested review from a team and ericyz as code owners December 17, 2024 00:20
@apeabody
Copy link
Collaborator

From the lint test:

terraform_validate ./examples/simple_autopilot_public
╷
│ Error: Unsupported argument
│ 
│   on main.tf line 52, in module "gke":
│   52:   gcs_fuse_csi_driver             = true
│ 
│ An argument named "gcs_fuse_csi_driver" is not expected here.

@apeabody apeabody self-assigned this Dec 18, 2024
@apeabody
Copy link
Collaborator

This can be included in v35.0.1

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

Fuse CSI Driver is not supported for autopilot

For clarify: "The Cloud Storage FUSE CSI driver is enabled by default for Autopilot clusters."

@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @DrFaust92!

Given the removal of the variable for Autopilot clusters, I think we'll want to classify this as a breaking change. Thoughts? Otherwise this LGTM.

@apeabody apeabody added the blocked Blocked by some other work label Dec 24, 2024
@DrFaust92
Copy link
Contributor Author

apeabody Im fine with as i prefer err on the side of caution. but I dont think its breaking as it not supported toggle anyway

@apeabody
Copy link
Collaborator

apeabody Im fine with as i prefer err on the side of caution. but I dont think its breaking as it not supported toggle anyway

Agreed - It's an usual edge case as the cluster "behavior" doesn't change, but if present they would need to remove gcs_fuse_csi_driver = true.

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DrFaust92! For caution we'll wait to include a major version, but otherwise LGTM.

@apeabody
Copy link
Collaborator

apeabody commented Jan 3, 2025

/gcbrun

@apeabody
Copy link
Collaborator

apeabody commented Jan 3, 2025

/gcbrun

@apeabody apeabody removed the blocked Blocked by some other work label Jan 3, 2025
@apeabody apeabody enabled auto-merge (squash) January 3, 2025 19:16
@apeabody apeabody merged commit 271af34 into terraform-google-modules:master Jan 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants