Skip to content

Fix: dns endpoint for external traffic #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 24, 2025
Merged

Fix: dns endpoint for external traffic #2244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2f764c1
Fix dns endpoint for external traffic
mmorejon Jan 15, 2025
9fef9fc
Merge branch 'main' into fix-dns-endpoint-config
mmorejon Jan 16, 2025
5225b8a
Merge branch 'main' into fix-dns-endpoint-config
mmorejon Jan 20, 2025
7a844a8
Merge branch 'main' into fix-dns-endpoint-config
apeabody Jan 22, 2025
86980c0
Merge branch 'main' into fix-dns-endpoint-config
apeabody Jan 22, 2025
04f067d
Update cluster-iap-bastion example
mmorejon Jan 24, 2025
0b0b2cd
Merge branch 'main' into fix-dns-endpoint-config
mmorejon Jan 24, 2025
65fca44
Merge branch 'main' into fix-dns-endpoint-config
apeabody Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion autogen/main/cluster.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@ resource "google_container_cluster" "primary" {
}

dynamic "control_plane_endpoints_config" {
for_each = var.enable_private_endpoint && var.deploy_using_private_endpoint ? [1] : [0]
for_each = var.enable_private_endpoint && var.deploy_using_private_endpoint ? [1] : []
content {
dns_endpoint_config {
allow_external_traffic = var.deploy_using_private_endpoint
Expand Down
2 changes: 1 addition & 1 deletion examples/safer_cluster_iap_bastion/cluster.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ module "gke" {
subnetwork = module.vpc.subnets_names[0]
ip_range_pods = module.vpc.subnets_secondary_ranges[0][0].range_name
ip_range_services = module.vpc.subnets_secondary_ranges[0][1].range_name
enable_private_endpoint = false
enable_private_endpoint = true
deletion_protection = false
master_authorized_networks = [{
cidr_block = "${module.bastion.ip_address}/32"
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-autopilot-private-cluster/cluster.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ resource "google_container_cluster" "primary" {
}

dynamic "control_plane_endpoints_config" {
for_each = var.enable_private_endpoint && var.deploy_using_private_endpoint ? [1] : [0]
for_each = var.enable_private_endpoint && var.deploy_using_private_endpoint ? [1] : []
content {
dns_endpoint_config {
allow_external_traffic = var.deploy_using_private_endpoint
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-private-cluster-update-variant/cluster.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ resource "google_container_cluster" "primary" {
}

dynamic "control_plane_endpoints_config" {
for_each = var.enable_private_endpoint && var.deploy_using_private_endpoint ? [1] : [0]
for_each = var.enable_private_endpoint && var.deploy_using_private_endpoint ? [1] : []
content {
dns_endpoint_config {
allow_external_traffic = var.deploy_using_private_endpoint
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-private-cluster/cluster.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ resource "google_container_cluster" "primary" {
}

dynamic "control_plane_endpoints_config" {
for_each = var.enable_private_endpoint && var.deploy_using_private_endpoint ? [1] : [0]
for_each = var.enable_private_endpoint && var.deploy_using_private_endpoint ? [1] : []
content {
dns_endpoint_config {
allow_external_traffic = var.deploy_using_private_endpoint
Expand Down
2 changes: 1 addition & 1 deletion modules/private-cluster-update-variant/cluster.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ resource "google_container_cluster" "primary" {
}

dynamic "control_plane_endpoints_config" {
for_each = var.enable_private_endpoint && var.deploy_using_private_endpoint ? [1] : [0]
for_each = var.enable_private_endpoint && var.deploy_using_private_endpoint ? [1] : []
content {
dns_endpoint_config {
allow_external_traffic = var.deploy_using_private_endpoint
Expand Down
2 changes: 1 addition & 1 deletion modules/private-cluster/cluster.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ resource "google_container_cluster" "primary" {
}

dynamic "control_plane_endpoints_config" {
for_each = var.enable_private_endpoint && var.deploy_using_private_endpoint ? [1] : [0]
for_each = var.enable_private_endpoint && var.deploy_using_private_endpoint ? [1] : []
content {
dns_endpoint_config {
allow_external_traffic = var.deploy_using_private_endpoint
Expand Down
Loading