Skip to content

fix(main): unmark endpoint as sensitive #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 22, 2025
Merged

fix(main): unmark endpoint as sensitive #2249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
22057f6
fix(main): unmark `endpoint` as sensitive
wyardley Jan 21, 2025
5096eb3
update tests
wyardley Jan 21, 2025
25b130b
fix example formatting
wyardley Jan 21, 2025
6a2c828
Merge branch 'main' into wyardley/2248
apeabody Jan 22, 2025
0746e94
Merge branch 'main' into wyardley/2248
apeabody Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion autogen/main/outputs.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ output "zones" {
}

output "endpoint" {
sensitive = true
description = "Cluster endpoint"
value = local.cluster_endpoint
depends_on = [
Expand Down
3 changes: 1 addition & 2 deletions examples/simple_regional_private_with_cluster_version/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
*/

output "kubernetes_endpoint" {
sensitive = true
value = module.gke.endpoint
value = module.gke.endpoint
}

output "client_token" {
Expand Down
1 change: 0 additions & 1 deletion modules/beta-autopilot-private-cluster/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ output "zones" {
}

output "endpoint" {
sensitive = true
description = "Cluster endpoint"
value = local.cluster_endpoint
depends_on = [
Expand Down
1 change: 0 additions & 1 deletion modules/beta-autopilot-public-cluster/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ output "zones" {
}

output "endpoint" {
sensitive = true
description = "Cluster endpoint"
value = local.cluster_endpoint
depends_on = [
Expand Down
1 change: 0 additions & 1 deletion modules/beta-private-cluster-update-variant/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ output "zones" {
}

output "endpoint" {
sensitive = true
description = "Cluster endpoint"
value = local.cluster_endpoint
depends_on = [
Expand Down
1 change: 0 additions & 1 deletion modules/beta-private-cluster/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ output "zones" {
}

output "endpoint" {
sensitive = true
description = "Cluster endpoint"
value = local.cluster_endpoint
depends_on = [
Expand Down
1 change: 0 additions & 1 deletion modules/beta-public-cluster-update-variant/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ output "zones" {
}

output "endpoint" {
sensitive = true
description = "Cluster endpoint"
value = local.cluster_endpoint
depends_on = [
Expand Down
1 change: 0 additions & 1 deletion modules/beta-public-cluster/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ output "zones" {
}

output "endpoint" {
sensitive = true
description = "Cluster endpoint"
value = local.cluster_endpoint
depends_on = [
Expand Down
1 change: 0 additions & 1 deletion modules/private-cluster-update-variant/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ output "zones" {
}

output "endpoint" {
sensitive = true
description = "Cluster endpoint"
value = local.cluster_endpoint
depends_on = [
Expand Down
1 change: 0 additions & 1 deletion modules/private-cluster/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ output "zones" {
}

output "endpoint" {
sensitive = true
description = "Cluster endpoint"
value = local.cluster_endpoint
depends_on = [
Expand Down
1 change: 0 additions & 1 deletion outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ output "zones" {
}

output "endpoint" {
sensitive = true
description = "Cluster endpoint"
value = local.cluster_endpoint
depends_on = [
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/autopilot_private_firewalls/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "ca_certificate" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/beta_cluster/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.this.kubernetes_endpoint
value = module.this.kubernetes_endpoint
}

output "service_account" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/deploy_service/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/disable_client_cert/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/node_pool/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/node_pool_update_variant/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/private_zonal_with_networking/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ output "cluster_name" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/safer_cluster/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/sandbox_enabled/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/shared_vpc/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/simple_autopilot_private/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "ca_certificate" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/simple_autopilot_public/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "ca_certificate" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/simple_regional/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/simple_regional_cluster_autoscaling/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/simple_regional_private/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/simple_regional_private_with_cluster_version/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/simple_regional_with_gateway_api/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/simple_regional_with_ipv6/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/simple_regional_with_kubeconfig/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/simple_regional_with_networking/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ output "cluster_name" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/simple_windows_node_pool/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.this.kubernetes_endpoint
value = module.this.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/simple_zonal/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/simple_zonal_private/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/simple_zonal_with_asm/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/stub_domains/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/stub_domains_private/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/stub_domains_upstream_nameservers/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/upstream_nameservers/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/workload_identity/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ output "location" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
3 changes: 1 addition & 2 deletions test/fixtures/workload_metadata_config/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ output "master_kubernetes_version" {
}

output "kubernetes_endpoint" {
sensitive = true
value = module.example.kubernetes_endpoint
value = module.example.kubernetes_endpoint
}

output "client_token" {
Expand Down
Loading