-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat(cgroup): add support for configuring Linux cgroup mode in autopilot clusters #2282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cgroup): add support for configuring Linux cgroup mode in autopilot clusters #2282
Conversation
ed85cfe to
ca6fcc6
Compare
…lot clusters This update introduces a new `linux_cgroup_mode` variable to specify the cgroup hierarchy mode for autopilot Kubernetes nodes. Supported values include `CGROUP_MODE_UNSPECIFIED`, `CGROUP_MODE_V1`, and `CGROUP_MODE_V2`. Adjusted cluster configurations to include dynamic management of the Linux node configuration based on this variable.
Updated the condition block in `node_pools_cgroup_mode` validation across multiple variables files to use a more readable multi-line format.
Updated variable validation logic to use the `coalesce` function instead of conditional operators for `node_pools_cgroup_mode`, improving readability and consistency across modules.
…ables.tf`" This reverts commit 7434326.
9bd0855 to
efe18f2
Compare
I think this issue will be quickly deprecated |
Yes, here is the plan for Standard: https://cloud.google.com/kubernetes-engine/docs/how-to/migrate-cgroupv2#transition-plan I've requested additional clarification for Autopilot. Ref: |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
apeabody
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @Ameausoone!
We would also want to add example/test coverage for this changes similar to #2273
apeabody
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Ameausoone!
Could you please add to an example, so we have test coverage for this changes. Could be similar to #2273
Thanks!
…stant changes Co-authored-by:scipe
|
@apeabody ok I fixed the network_tags block issue, and add examples. |
|
/gcbrun |
|
BTW: I'm trying to use module-swapper to execute integration tests locally but no way to find the good args. I run : It outputs : But there is no modification.. |
|
/gcbrun |
|
/gcbrun |
apeabody
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @Ameausoone!
feat(hugepage_config): fixing some errors related to hugepage config mapping feat: add hyperdisk confidential node pool to the confidential safer cluster example (terraform-google-modules#2311) feat(cgroup): add support for configuring Linux cgroup mode in autopilot clusters (terraform-google-modules#2282) chore(main): release 36.2.0 (terraform-google-modules#2312) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> feat(hugepage): Adding hugepage support linux node configuration (terraform-google-modules#2320)
This update introduces a new
linux_cgroup_modevariable to specify the cgroup hierarchy mode for autopilot Kubernetes nodes. Supported values includeCGROUP_MODE_UNSPECIFIED,CGROUP_MODE_V1, andCGROUP_MODE_V2. Adjusted cluster configurations to include dynamic management of the Linux node configuration based on this variable.Closes #2264