Skip to content

Conversation

@Ameausoone
Copy link
Contributor

@Ameausoone Ameausoone commented Feb 13, 2025

This update introduces a new linux_cgroup_mode variable to specify the cgroup hierarchy mode for autopilot Kubernetes nodes. Supported values include CGROUP_MODE_UNSPECIFIED, CGROUP_MODE_V1, and CGROUP_MODE_V2. Adjusted cluster configurations to include dynamic management of the Linux node configuration based on this variable.

  • make build

Closes #2264

…lot clusters

This update introduces a new `linux_cgroup_mode` variable to specify the cgroup hierarchy mode for autopilot Kubernetes nodes. Supported values include `CGROUP_MODE_UNSPECIFIED`, `CGROUP_MODE_V1`, and `CGROUP_MODE_V2`. Adjusted cluster configurations to include dynamic management of the Linux node configuration based on this variable.
Updated the condition block in `node_pools_cgroup_mode` validation across multiple variables files to use a more readable multi-line format.
Updated variable validation logic to use the `coalesce` function instead of conditional operators for `node_pools_cgroup_mode`, improving readability and consistency across modules.
@Ameausoone
Copy link
Contributor Author

      ~ node_pool_auto_config {
            # (1 unchanged attribute hidden)

          ~ linux_node_config {
              ~ cgroup_mode = "CGROUP_MODE_V2" -> "CGROUP_MODE_V1"
            }

          + network_tags {}
        }

....
│ Error: googleapi: Error 400: Setting cgroup_mode to v1 is not allowed for clusters created with version 1.31.4-gke.1372000.
│

I think this issue will be quickly deprecated

@apeabody
Copy link
Collaborator

      ~ node_pool_auto_config {
            # (1 unchanged attribute hidden)

          ~ linux_node_config {
              ~ cgroup_mode = "CGROUP_MODE_V2" -> "CGROUP_MODE_V1"
            }

          + network_tags {}
        }

....
│ Error: googleapi: Error 400: Setting cgroup_mode to v1 is not allowed for clusters created with version 1.31.4-gke.1372000.
│

I think this issue will be quickly deprecated

Yes, here is the plan for Standard: https://cloud.google.com/kubernetes-engine/docs/how-to/migrate-cgroupv2#transition-plan I've requested additional clarification for Autopilot.

Ref:
https://cloud.google.com/kubernetes-engine/docs/release-schedule#schedule-for-release-channels

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @Ameausoone!

We would also want to add example/test coverage for this changes similar to #2273

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Ameausoone!

Could you please add to an example, so we have test coverage for this changes. Could be similar to #2273

Thanks!

@Ameausoone
Copy link
Contributor Author

@apeabody ok I fixed the network_tags block issue, and add examples.

@apeabody
Copy link
Collaborator

apeabody commented Mar 6, 2025

/gcbrun

@Ameausoone
Copy link
Contributor Author

BTW: I'm trying to use module-swapper to execute integration tests locally but no way to find the good args.

I run : docker run --rm -v "$(pwd):/workspace/" gcr.io/cloud-foundation-cicd/cft/developer-tools:1.23 module-swapper

It outputs :

...
2025/03/11 12:52:01 Modifications made to file /workspace/examples/simple_zonal_with_hub/main.tf
....

But there is no modification..

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

apeabody commented Apr 3, 2025

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @Ameausoone!

@apeabody apeabody merged commit 5069034 into terraform-google-modules:main Apr 3, 2025
4 checks passed
rawanbadawi added a commit to rawanbadawi/terraform-google-kubernetes-engine that referenced this pull request Apr 4, 2025
feat(hugepage_config): fixing some errors related to hugepage config mapping

feat: add hyperdisk confidential node pool to the confidential safer cluster example (terraform-google-modules#2311)

feat(cgroup): add support for configuring Linux cgroup mode in autopilot clusters (terraform-google-modules#2282)

chore(main): release 36.2.0 (terraform-google-modules#2312)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

feat(hugepage): Adding hugepage support linux node configuration (terraform-google-modules#2320)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No option to set cgroup under beta-autopilot-private-cluster

2 participants