Skip to content

feat(TPG>=6.33)!: allow update in-place for enable_gvnic and enable_confidential_nodes #2359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025
Merged

feat(TPG>=6.33)!: allow update in-place for enable_gvnic and enable_confidential_nodes #2359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0487ec5
enable in place update for gvnic and confidential nodes
DrFaust92 May 30, 2025
1f5c30b
rebase
DrFaust92 May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ The [project factory](https://github.com/terraform-google-modules/terraform-goog
#### Terraform and Plugins

- [Terraform](https://www.terraform.io/downloads.html) 1.3+
- [Terraform Provider for GCP][terraform-provider-google] v6.28+
- [Terraform Provider for GCP][terraform-provider-google] v6.33+

#### gcloud

Expand Down
4 changes: 2 additions & 2 deletions autogen/main/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,9 +306,9 @@ The [project factory](https://github.com/terraform-google-modules/terraform-goog

- [Terraform](https://www.terraform.io/downloads.html) 1.3+
{% if beta_cluster %}
- [Terraform Provider for GCP Beta][terraform-provider-google-beta] v6.28+
- [Terraform Provider for GCP Beta][terraform-provider-google-beta] v6.33+
{% else %}
- [Terraform Provider for GCP][terraform-provider-google] v6.28+
- [Terraform Provider for GCP][terraform-provider-google] v6.33+
{% endif %}

#### gcloud
Expand Down
2 changes: 0 additions & 2 deletions autogen/main/cluster.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,14 +811,12 @@ locals {
"preemptible",
"spot",
"service_account",
"enable_gvnic",
"boot_disk_kms_key",
"queued_provisioning",
"enable_confidential_storage",
"consume_reservation_type",
"reservation_affinity_key",
"reservation_affinity_values",
"enable_confidential_nodes",
"secondary_boot_disk",
"local_ssd_encryption_mode",
]
Expand Down
12 changes: 6 additions & 6 deletions autogen/main/versions.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,33 +24,33 @@ terraform {
required_providers {
google = {
source = "hashicorp/google"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
google-beta = {
source = "hashicorp/google-beta"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
{% elif beta_cluster and autopilot_cluster %}
required_providers {
google = {
source = "hashicorp/google"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
google-beta = {
source = "hashicorp/google-beta"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
{% elif autopilot_cluster %}
required_providers {
google = {
source = "hashicorp/google"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
{% else %}
required_providers {
google = {
source = "hashicorp/google"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
{% endif %}
kubernetes = {
Expand Down
Empty file added core
View file
Open in desktop
Empty file.
2 changes: 1 addition & 1 deletion modules/beta-autopilot-private-cluster/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ The [project factory](https://github.com/terraform-google-modules/terraform-goog
#### Terraform and Plugins

- [Terraform](https://www.terraform.io/downloads.html) 1.3+
- [Terraform Provider for GCP Beta][terraform-provider-google-beta] v6.28+
- [Terraform Provider for GCP Beta][terraform-provider-google-beta] v6.33+

#### gcloud

Expand Down
4 changes: 2 additions & 2 deletions modules/beta-autopilot-private-cluster/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ terraform {
required_providers {
google = {
source = "hashicorp/google"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
google-beta = {
source = "hashicorp/google-beta"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
kubernetes = {
source = "hashicorp/kubernetes"
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-autopilot-public-cluster/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ The [project factory](https://github.com/terraform-google-modules/terraform-goog
#### Terraform and Plugins

- [Terraform](https://www.terraform.io/downloads.html) 1.3+
- [Terraform Provider for GCP Beta][terraform-provider-google-beta] v6.28+
- [Terraform Provider for GCP Beta][terraform-provider-google-beta] v6.33+

#### gcloud

Expand Down
4 changes: 2 additions & 2 deletions modules/beta-autopilot-public-cluster/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ terraform {
required_providers {
google = {
source = "hashicorp/google"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
google-beta = {
source = "hashicorp/google-beta"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
kubernetes = {
source = "hashicorp/kubernetes"
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-private-cluster-update-variant/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ The [project factory](https://github.com/terraform-google-modules/terraform-goog
#### Terraform and Plugins

- [Terraform](https://www.terraform.io/downloads.html) 1.3+
- [Terraform Provider for GCP Beta][terraform-provider-google-beta] v6.28+
- [Terraform Provider for GCP Beta][terraform-provider-google-beta] v6.33+

#### gcloud

Expand Down
2 changes: 0 additions & 2 deletions modules/beta-private-cluster-update-variant/cluster.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,14 +693,12 @@ locals {
"preemptible",
"spot",
"service_account",
"enable_gvnic",
"boot_disk_kms_key",
"queued_provisioning",
"enable_confidential_storage",
"consume_reservation_type",
"reservation_affinity_key",
"reservation_affinity_values",
"enable_confidential_nodes",
"secondary_boot_disk",
"local_ssd_encryption_mode",
]
Expand Down
4 changes: 2 additions & 2 deletions modules/beta-private-cluster-update-variant/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ terraform {
required_providers {
google = {
source = "hashicorp/google"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
google-beta = {
source = "hashicorp/google-beta"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
kubernetes = {
source = "hashicorp/kubernetes"
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-private-cluster/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ The [project factory](https://github.com/terraform-google-modules/terraform-goog
#### Terraform and Plugins

- [Terraform](https://www.terraform.io/downloads.html) 1.3+
- [Terraform Provider for GCP Beta][terraform-provider-google-beta] v6.28+
- [Terraform Provider for GCP Beta][terraform-provider-google-beta] v6.33+

#### gcloud

Expand Down
4 changes: 2 additions & 2 deletions modules/beta-private-cluster/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ terraform {
required_providers {
google = {
source = "hashicorp/google"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
google-beta = {
source = "hashicorp/google-beta"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
kubernetes = {
source = "hashicorp/kubernetes"
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-public-cluster-update-variant/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ The [project factory](https://github.com/terraform-google-modules/terraform-goog
#### Terraform and Plugins

- [Terraform](https://www.terraform.io/downloads.html) 1.3+
- [Terraform Provider for GCP Beta][terraform-provider-google-beta] v6.28+
- [Terraform Provider for GCP Beta][terraform-provider-google-beta] v6.33+

#### gcloud

Expand Down
2 changes: 0 additions & 2 deletions modules/beta-public-cluster-update-variant/cluster.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,14 +671,12 @@ locals {
"preemptible",
"spot",
"service_account",
"enable_gvnic",
"boot_disk_kms_key",
"queued_provisioning",
"enable_confidential_storage",
"consume_reservation_type",
"reservation_affinity_key",
"reservation_affinity_values",
"enable_confidential_nodes",
"secondary_boot_disk",
"local_ssd_encryption_mode",
]
Expand Down
4 changes: 2 additions & 2 deletions modules/beta-public-cluster-update-variant/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ terraform {
required_providers {
google = {
source = "hashicorp/google"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
google-beta = {
source = "hashicorp/google-beta"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
kubernetes = {
source = "hashicorp/kubernetes"
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-public-cluster/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ The [project factory](https://github.com/terraform-google-modules/terraform-goog
#### Terraform and Plugins

- [Terraform](https://www.terraform.io/downloads.html) 1.3+
- [Terraform Provider for GCP Beta][terraform-provider-google-beta] v6.28+
- [Terraform Provider for GCP Beta][terraform-provider-google-beta] v6.33+

#### gcloud

Expand Down
4 changes: 2 additions & 2 deletions modules/beta-public-cluster/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ terraform {
required_providers {
google = {
source = "hashicorp/google"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
google-beta = {
source = "hashicorp/google-beta"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
kubernetes = {
source = "hashicorp/kubernetes"
Expand Down
2 changes: 1 addition & 1 deletion modules/private-cluster-update-variant/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ The [project factory](https://github.com/terraform-google-modules/terraform-goog
#### Terraform and Plugins

- [Terraform](https://www.terraform.io/downloads.html) 1.3+
- [Terraform Provider for GCP][terraform-provider-google] v6.28+
- [Terraform Provider for GCP][terraform-provider-google] v6.33+

#### gcloud

Expand Down
2 changes: 0 additions & 2 deletions modules/private-cluster-update-variant/cluster.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,14 +640,12 @@ locals {
"preemptible",
"spot",
"service_account",
"enable_gvnic",
"boot_disk_kms_key",
"queued_provisioning",
"enable_confidential_storage",
"consume_reservation_type",
"reservation_affinity_key",
"reservation_affinity_values",
"enable_confidential_nodes",
"secondary_boot_disk",
"local_ssd_encryption_mode",
]
Expand Down
2 changes: 1 addition & 1 deletion modules/private-cluster-update-variant/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ terraform {
required_providers {
google = {
source = "hashicorp/google"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
kubernetes = {
source = "hashicorp/kubernetes"
Expand Down
2 changes: 1 addition & 1 deletion modules/private-cluster/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ The [project factory](https://github.com/terraform-google-modules/terraform-goog
#### Terraform and Plugins

- [Terraform](https://www.terraform.io/downloads.html) 1.3+
- [Terraform Provider for GCP][terraform-provider-google] v6.28+
- [Terraform Provider for GCP][terraform-provider-google] v6.33+

#### gcloud

Expand Down
2 changes: 1 addition & 1 deletion modules/private-cluster/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ terraform {
required_providers {
google = {
source = "hashicorp/google"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
kubernetes = {
source = "hashicorp/kubernetes"
Expand Down
2 changes: 1 addition & 1 deletion versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ terraform {
required_providers {
google = {
source = "hashicorp/google"
version = ">= 6.28.0, < 7"
version = ">= 6.33.0, < 7"
}
kubernetes = {
source = "hashicorp/kubernetes"
Expand Down