Skip to content

Commit 12caacc

Browse files
authored
fix: support providing null port for creating firewall to support USE_SERVING_PORT (#488)
1 parent b820ee0 commit 12caacc

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

modules/backend/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,6 @@ resource "google_compute_firewall" "default-hc" {
286286

287287
allow {
288288
protocol = "tcp"
289-
ports = [var.health_check.port]
289+
ports = var.health_check.port != null ? [var.health_check.port] : null
290290
}
291291
}

modules/backend/metadata.display.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ spec:
7070
host_path_mappings:
7171
name: host_path_mappings
7272
title: Host Path Mappings
73+
level: 1
7374
iap_config:
7475
name: iap_config
7576
title: Iap Config
@@ -85,6 +86,8 @@ spec:
8586
name:
8687
name: name
8788
title: Name
89+
regexValidation: ^[a-z][a-z0-9-]{0,40}[a-z0-9]$
90+
validation: Use lowercase letters, numbers, and hyphens. Start with a letter and end with letter/number. Must be 42 characters or fewer.
8891
outlier_detection:
8992
name: outlier_detection
9093
title: Outlier Detection

modules/frontend/metadata.display.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,8 @@ spec:
8282
name:
8383
name: name
8484
title: Name
85+
regexValidation: ^[a-z][a-z0-9-]{0,34}[a-z0-9]$
86+
validation: Use lowercase letters, numbers, and hyphens. Start with a letter and end with letter/number. Must be 36 characters or fewer.
8587
network:
8688
name: network
8789
title: Network

0 commit comments

Comments
 (0)