fix: avoid creating hc firewall rule if health_check not defined (#476)

Andrew Vella · av603 · commit ecd2c5cd3665 · 2024-12-23T11:55:58.000+11:00
diff --git a/main.tf b/main.tf
@@ -433,7 +433,7 @@ resource "google_compute_health_check" "default" {
 }
 
 resource "google_compute_firewall" "default-hc" {
-  count   = length(var.firewall_networks)
+  count = length(var.firewall_networks) && (length(local.health_checked_backends) > 0) ? 1 : 0
   project = length(var.firewall_networks) == 1 && var.firewall_projects[0] == "default" ? var.project : var.firewall_projects[count.index]
   name    = "${var.name}-hc-${count.index}"
   network = var.firewall_networks[count.index]

Original file line number	Diff line number	Diff line change
`@@ -433,7 +433,7 @@ resource "google_compute_health_check" "default" {`
`433`	`433`	`}`
`434`	`434`
`435`	`435`	`resource "google_compute_firewall" "default-hc" {`
`436`		`- count = length(var.firewall_networks)`
	`436`	`+ count = length(var.firewall_networks) && (length(local.health_checked_backends) > 0) ? 1 : 0`
`437`	`437`	`project = length(var.firewall_networks) == 1 && var.firewall_projects[0] == "default" ? var.project : var.firewall_projects[count.index]`
`438`	`438`	`name = "${var.name}-hc-${count.index}"`
`439`	`439`	`network = var.firewall_networks[count.index]`