feat!: update default for cdn_policy and do not create serverless neg #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault for cdn_policy
bharathkkb
approved these changes
Jun 30, 2025
| })) | ||
| }) | ||
| default = {} | ||
| default = { |
Collaborator
Author
There was a problem hiding this comment.
- cdn_policy takes effect only if enable_cdn is set which is false by default.
- Any user who have set enable_cdn would have already set cdn_policy as it is needed by backend_service. User defined cdn_policy will take effect.
- The only impact would be if users have set enable_cdn with backend_bucket. The default behavior for cdn_policy would change.
We can mark this as breaking change.
bharathkkb
changed the title
q2w
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.